Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Performance Hints of this URL won't clear the home page qs #6883

Closed
hanna-meda opened this issue Aug 21, 2024 · 0 comments · Fixed by #6886
Closed

Clear Performance Hints of this URL won't clear the home page qs #6883

hanna-meda opened this issue Aug 21, 2024 · 0 comments · Fixed by #6886
Assignees
Labels
module: ALR Issues related to the Automatic Lazy Rendering feature type: bug Indicates an unexpected problem or unintended behavior type: regression Indicates issues that have reintroduced previously fixed bugs or caused a decrease in performance
Milestone

Comments

@hanna-meda
Copy link

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version ✓ branch 3.17/6845-subtask-data-clearing-notices
  • Used the search feature to ensure that the bug hasn’t been reported before ✓

Describe the bug
Using the "Clear Performance Hints of this URL" on the view page of home, will not clear the home page qs URLs.

To Reproduce
Steps to reproduce the behavior:

  1. In the wp-admin of testing site, go to WPR settings > Advanced Rules and add 'test', 'lang', gclid' under the "Cache Query String(s) section & Save changes.
  2. Visit homepage, homepage/?test, homepage?lang=en, homepage?test&lang=1&?gclid=something and check all pages are cached
  3. In the admin, view the home page and click "Clear Performance Hints data of this URL" from top bar > WPR menu
  4. Inspect cache folder and notice that the cache of home and home with qs are not deleted.

Related TC.

Expected behavior
Should clear the cache of the home page and home page qs when using "Clear Performance Hints of this URL".

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@hanna-meda hanna-meda added the module: ALR Issues related to the Automatic Lazy Rendering feature label Aug 21, 2024
@hanna-meda hanna-meda added this to the 3.17 milestone Aug 21, 2024
@Khadreal Khadreal self-assigned this Aug 21, 2024
@hanna-meda hanna-meda added type: bug Indicates an unexpected problem or unintended behavior type: regression Indicates issues that have reintroduced previously fixed bugs or caused a decrease in performance labels Aug 21, 2024
@Khadreal Khadreal linked a pull request Aug 21, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: ALR Issues related to the Automatic Lazy Rendering feature type: bug Indicates an unexpected problem or unintended behavior type: regression Indicates issues that have reintroduced previously fixed bugs or caused a decrease in performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants