-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 error in console on Safari when LazyLoad for CSS BG Images is active #6453
Comments
I can't replicate this on Safari, I dont'have the error on console with lazyload CSS enabled |
If you check on firefox it shows the 404 error for lazyload-css.min.js.map |
I have a similar case. Found this: https://goonlinetools.com/snapshot/code/#5hmlsyg75yfn5wz8d5l0y //# sourceMappingURL=lazyload-css.min.js.map But This is the ticket: https://secure.helpscout.net/conversation/2586260422/489478 |
We aren't generating the map file when gulp run, coincidentally this PR(#6625) fix the issue. |
@MathieuLamiot , if #6625 is fixing it, should we close this issue ? |
Yes, after confirming it's fixed. |
The file exists and is correctly mapped in the min file, we do have a stray |
Closing the issue as the files have been updated to correctly match. Please re-open if the issue arise again. |
@piotrbak The issue here is that we are injecting the script on pages, which result on the sourcemap becoming relative path Consequently, whatever is looking for sourcemap will look for it on the same current page's path. Either remove the sourcemap or reference an absolute path for the sourcemap or include it as a file and not inline it. |
Moving it to the current sprint as there is a PR ready. |
Co-authored-by: Gael Robin <[email protected]>
Same here |
Describe the bug
When LazyLoad for CSS Background Images is active, Safari shows a 404 error in the console for:
lazyload-css.min.js.map
It doesn't seem to break anything, but we shouldn't cause a console error.
To Reproduce
Steps to reproduce the behavior:
Tested on WPR 3.15.9
Expected behavior
No 404.
Screenshots
If applicable, add screenshots to help explain your problem.
Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
The text was updated successfully, but these errors were encountered: