Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect parameter passed to the increment_retries #6314

Closed
jeawhanlee opened this issue Dec 11, 2023 · 0 comments · Fixed by #6317
Closed

Incorrect parameter passed to the increment_retries #6314

jeawhanlee opened this issue Dec 11, 2023 · 0 comments · Fixed by #6317
Assignees
@remyperona
Labels
effort: [XS] < 1 day of estimated development time module: remove unused css priority: medium Issues which are important, but no one will go out of business. severity: minor Defect that does not affect functionality type: bug Indicates an unexpected problem or unintended behavior
Milestone
3.15.7

Comments

@jeawhanlee
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
we pass the retries here as the 2nd param here while the expected parameter is the the error_code.

Expected behavior
We need to pass the error_code instead.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
@jeawhanlee jeawhanlee added type: bug Indicates an unexpected problem or unintended behavior module: remove unused css labels Dec 11, 2023
@piotrbak piotrbak added priority: medium Issues which are important, but no one will go out of business. needs: grooming severity: minor Defect that does not affect functionality labels Dec 11, 2023
@piotrbak piotrbak added this to the 3.15.7 milestone Dec 11, 2023
@remyperona remyperona mentioned this issue Dec 11, 2023
Merged
5 tasks
@remyperona remyperona self-assigned this Dec 11, 2023
@remyperona remyperona added effort: [XS] < 1 day of estimated development time and removed needs: grooming labels Dec 11, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 13, 2023
@remyperona
Fixes #6314 Pass the error code instead of the retries count in the R…
2b2243e 
…UCSS strategy (#6317)
@remyperona remyperona mentioned this issue Jan 4, 2024
Merged
wordpressfan pushed a commit that referenced this issue Mar 15, 2024
@remyperona @wordpressfan
Fixes #6314 Pass the error code instead of the retries count in the R…
8e60a8b 
…UCSS strategy (#6317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remyperona remyperona

Labels
effort: [XS] < 1 day of estimated development time module: remove unused css priority: medium Issues which are important, but no one will go out of business. severity: minor Defect that does not affect functionality type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.15.7
3 participants
@remyperona @piotrbak @jeawhanlee