Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LazyLoad CSS Background Images: Create skeleton #6000

Closed
CrochetFeve0251 opened this issue Jun 21, 2023 · 0 comments · Fixed by #6004
Closed

LazyLoad CSS Background Images: Create skeleton #6000

CrochetFeve0251 opened this issue Jun 21, 2023 · 0 comments · Fixed by #6004
Assignees
Labels
effort: [XS] < 1 day of estimated development time project Issues part of the project focus board type: new feature Indicates the issue is a request for new functionality type: sub-task Indicates the issue is a sub-task linked to an epics card
Milestone

Comments

@CrochetFeve0251
Copy link
Contributor

Subtask #5987

As some subtasks are based on some classes that other sub tasks should implements. We would require to create skeleton of empty classes with all public methods that then could be used while testing an sub-task requiring object from another or simply make sure the data flow is correct.

For that we will have to create the following classes:

  • WP_Rocket\Engine\Common\ExtractCSS\Subscriber implementing WP_Rocket\EventManagement\SubscriberInterface with the following methods:
    • get_subscribed_events
    • extract_css_files_from_html(array $data): array
    • extract_inline_css_from_html(array $data): array
  • WP_Rocket\Engine\Media\Lazyload\CSS\Subscriber implementing WP_Rocket\EventManagement\SubscriberInterface with the following methods:
    • get_subscribed_events
    • maybe_replace_css_images(string $html): string
    • clear_generated_css()
    • clear_generate_css_post(WP_POST $post)
    • insert_lazyload_script()
  • WP_Rocket\Engine\Media\Lazyload\CSS\Admin\Subscriber implementing WP_Rocket\EventManagement\SubscriberInterface with the following methods:
    • get_subscribed_events
    • add_meta_box(array $fields)
    • maybe_add_error_notice
  • WP_Rocket\Engine\Common\Cache/FilesystemCache implementing PSR-6 and with:
    • generate_url(string $url): string
@CrochetFeve0251 CrochetFeve0251 added effort: [XS] < 1 day of estimated development time type: new feature Indicates the issue is a request for new functionality type: sub-task Indicates the issue is a sub-task linked to an epics card labels Jun 21, 2023
@piotrbak piotrbak added this to the 3.15 milestone Jul 5, 2023
@MathieuLamiot MathieuLamiot added the project Issues part of the project focus board label Jul 12, 2023
@piotrbak piotrbak closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time project Issues part of the project focus board type: new feature Indicates the issue is a request for new functionality type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants