-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude the script for AMP redirection from Delay JS #4757
Labels
3rd party compatibility
Issues related to 3rd party compatibility like theme, plugin or hosting
effort: [XS]
< 1 day of estimated development time
good first issue
Indicates a good issue for first-time contributors
module: delay JS
priority: medium
Issues which are important, but no one will go out of business.
type: enhancement
Improvements that slightly enhance existing functionality and are fast to implement
Milestone
Comments
Mai-Saad
added
type: enhancement
Improvements that slightly enhance existing functionality and are fast to implement
3rd party compatibility
Issues related to 3rd party compatibility like theme, plugin or hosting
priority: medium
Issues which are important, but no one will go out of business.
module: delay JS
labels
Feb 22, 2022
Mai-Saad
changed the title
Exclude the script for AMP redirect from Delay JS
Exclude the script for AMP redirection from Delay JS
Feb 22, 2022
@Mai-Saad Which JS file or inline script must be excluded from Delay JS to have the redirection without user interaction? |
@GeekPress this is the inline script (using AMP v2.2.1)
excluding |
Scope a solution ✅Add Estimate the effort ✅Effort |
remyperona
added
the
good first issue
Indicates a good issue for first-time contributors
label
Mar 14, 2022
8 tasks
CrochetFeve0251
added a commit
that referenced
this issue
Apr 6, 2022
* Added amp-mobile-version-switcher to the HTML DelayJs exclusion array * Added amp-mobile-version-switcher script the delayJs fixture to ensure by automated testing that this script is not deleted * Reverted changes in DelayJS and fixtures corresponding to it. * Added a call to the filter rocket_delay_js_exclusions in the AMP Subscriber to exclude amp-mobile-version-switcher * Wrapped the filter rocket_delay_js_exclusions in the AMP verification to launch it only when it is activated * Fixed code standards * Added integration test for the exclude_script_from_delay_js method * Update version in inc/ThirdParty/Plugins/Optimization/AMP.php Co-authored-by: Rémy Perona <[email protected]> * Use configTestData instead of providerTestData tests/Integration/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Remove providerTestData function in tests/Integration/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Removed providerTestData mehod in tests/Unit/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Use configTestData instead of providerTestData in tests/Unit/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Update inc/ThirdParty/Plugins/Optimization/AMP.php Co-authored-by: Rémy Perona <[email protected]> * Update tests/Unit/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Update tests/Integration/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Added Integration TestCase Co-authored-by: Rémy Perona <[email protected]>
Merged
CrochetFeve0251
added a commit
that referenced
this issue
May 2, 2022
* Fixes #4757 Exclude AMP redirection script from delay JS (#4827) * Added amp-mobile-version-switcher to the HTML DelayJs exclusion array * Added amp-mobile-version-switcher script the delayJs fixture to ensure by automated testing that this script is not deleted * Reverted changes in DelayJS and fixtures corresponding to it. * Added a call to the filter rocket_delay_js_exclusions in the AMP Subscriber to exclude amp-mobile-version-switcher * Wrapped the filter rocket_delay_js_exclusions in the AMP verification to launch it only when it is activated * Fixed code standards * Added integration test for the exclude_script_from_delay_js method * Update version in inc/ThirdParty/Plugins/Optimization/AMP.php Co-authored-by: Rémy Perona <[email protected]> * Use configTestData instead of providerTestData tests/Integration/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Remove providerTestData function in tests/Integration/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Removed providerTestData mehod in tests/Unit/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Use configTestData instead of providerTestData in tests/Unit/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Update inc/ThirdParty/Plugins/Optimization/AMP.php Co-authored-by: Rémy Perona <[email protected]> * Update tests/Unit/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Update tests/Integration/inc/ThirdParty/Plugins/Optimization/AMP/excludeScriptFromDelayJs.php Co-authored-by: Rémy Perona <[email protected]> * Added Integration TestCase Co-authored-by: Rémy Perona <[email protected]> * Fixes #4804 Use absint values for width/height values when setting image dimensions of SVG files (#4805) * Fixes #4527 Remove Rocket option to deactivate lazyload of iframes and YT videos when Autoptimize lazyload is enabled (#4889) * Closes #4020 Delete metadata from the postmeta table during uninstall (#4855) * Closes #4133 Clean feeds only if our cache feeds helper plugin is enabled (#4833) * Fixes #4171 Exclude judge.me script from delay JS (#4839) * Fixes #4032 Disabling heartbeat causing dependency error in query monitor (#4888) * Prevent issues when parsing the HTML to apply optimizations (#4838) * Fixes #4758 Exclude our remove CPCSS script from delay JS (#4824) * Closes #4896 Update test suite (#4903) Update our test suite to be cross-compatible with WP and PHPUnit versions * Prevent PHP 8.1 deprecation notices (#4732) * Flatsome preserver dynamic #image_ style (PR #4979) Fixes #4971 * Preserve Health Center dynamic CSS selectors (PR #4976) * Closes #4867 Update the deactivation form UI (PR #4880) * Remove render class * move deactivation form assets to deactivation intent class * update classes instantiation * add subscriber class * update code for new deactivation intent form * delete new option and transient on uninstall * remove modal task * remove old modal CSS * remove old modal JS * use micromodal for deactivation modal * update the form HTML * update the modal CSS * update micromodal to v0.4.10 * return type hint * add transition * replace divs by list * remove unneeded comment * add missing semicolon * update activate_safe_mode tests * add unit tests * add fixtures * cast option to int * update used hooks * remove screen check * update test and fixture * integration tests * fix PHPCS * Fixes #4868 Apply CDN to used CSS on output instead of on saving (PR #4893) * Moved the filter and removed the clean_used_css_with_cdn method * Removed fixtures and integration tests from the method `clean_used_css_with_cdn` * Added unit tests for treeshake function from UsedCSS controller * Fixed code standards * Removed quotes * Fixed errors with the tests * replicate magic isset declaration from parent class * revert previous commit Co-authored-by: Rémy Perona <[email protected]> * Fix problem with action scheduler (PR #4965) * Added fix * Added fix standards * Added check on pending * Fixed search * Added fix standards * Fixed to conform to CR * Fixed code standards * Fixed code standards * Changed `search` method usage to keep backward compatibility * stop bailing out after cancel all actions Co-authored-by: Ahmed Saeed <[email protected]> * update plugin version * Fixed failing test (#4986) Co-authored-by: COQUARD Cyrille <[email protected]> Co-authored-by: Rémy Perona <[email protected]> Co-authored-by: Klemart3D <[email protected]> Co-authored-by: michael lee <[email protected]> Co-authored-by: Rémy Perona <[email protected]> Co-authored-by: Adame Dahmani <[email protected]> Co-authored-by: Vasilis Manthos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd party compatibility
Issues related to 3rd party compatibility like theme, plugin or hosting
effort: [XS]
< 1 day of estimated development time
good first issue
Indicates a good issue for first-time contributors
module: delay JS
priority: medium
Issues which are important, but no one will go out of business.
type: enhancement
Improvements that slightly enhance existing functionality and are fast to implement
Before submitting an issue please check that you’ve completed the following steps:
Describe the bug
The script which redirects mobile pages to the amp is delayed
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Amp redirect occurs without user interaction
Additional context
Add any other context about the problem here.
Backlog Grooming (for WP Media dev team use only)
The text was updated successfully, but these errors were encountered: