Fixes #609 conflict with wp cloudflare super page cache #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using our Bulk Page and requiring it in list of 3rd party plugins
engahmeds3ed
reviewed
Jan 3, 2022
| if ( | ||
| ! is_admin() | ||
| || | ||
| 'media_page_imagify-bulk-optimization' !== $hook_suffix |
There was a problem hiding this comment.
I believe that @markonikolic985 told me that we need to do that in all imagify admin pages not just only bulk optimization one, right?
… for all Imagify admin pages
iCaspar
approved these changes
Jan 20, 2022
|
Ready for @wp-media/qa |
remyperona
changed the title
GeekPress
approved these changes
Jul 5, 2022
remyperona
deleted the
fix/609-conflict-with-wp-cloudflare-super-page-cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #609
When both Imagify and WP Cloudflare Super Page Cache plugins are enabled at the same time, the Bulk Optimization will not start when "Imagif'em All' is pressed. This was due to the fact they both used the same Sweet Alert script and this caused a conflict.
This fixes that conflict by checking if the WP Cloudflare Super Page Cache Sweet Alert script is enqueued, and if so, it dequeues it.