Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #567 Prevent fatal error related to get_current_screen() #582

Merged
merged 4 commits into from
Jul 15, 2021
Merged

Fixes #567 Prevent fatal error related to get_current_screen() #582

merged 4 commits into from
Jul 15, 2021

Conversation

mostafa-hisham
Copy link
Contributor

issue #567
check if get_current_screen exists in yoast integration

@mostafa-hisham mostafa-hisham self-assigned this Jul 7, 2021
@mostafa-hisham mostafa-hisham requested a review from a team July 7, 2021 06:31
@mostafa-hisham mostafa-hisham marked this pull request as ready for review July 7, 2021 06:40
@remyperona remyperona linked an issue Jul 7, 2021 that may be closed by this pull request
Fatal error when Imagify, Gravity Forms, and the Gravity forms Mailchimp add-on plugins are all enabled and new Mailchimp feed is created #567
Closed
@iCaspar
Copy link
Contributor

iCaspar commented Jul 8, 2021

Ready for @wp-media/qa

Note, the presenting issue is not consistent. See #567 for possible plugin combinations to try.
At minimum, Imagify + Yoast must be involved.
Gravity Forms + Gravity Forms Mailchimp Extension were involved in one case.
A list of other possible plugins are in @joejoe04 comment on the issue.

@iCaspar iCaspar requested a review from a team July 8, 2021 17:22
@remyperona remyperona changed the title check if get_current_screen exists Fixes #567 Prevent fatal error related to get_current_screen Jul 8, 2021
@remyperona remyperona changed the title Fixes #567 Prevent fatal error related to get_current_screen Fixes #567 Prevent fatal error related to get_current_screen() Jul 8, 2021
@remyperona remyperona added this to the 1.10 milestone Jul 8, 2021
@iCaspar iCaspar mentioned this pull request Jul 12, 2021
Closed
4 tasks
@iCaspar iCaspar merged commit 8faefac into develop Jul 15, 2021
@iCaspar iCaspar deleted the fix/567-yoast-get-current-screen branch July 15, 2021 15:19
iCaspar added a commit that referenced this pull request Jul 15, 2021
@mostafa-hisham @iCaspar
Fixes #567 Prevent fatal error related to get_current_screen() (#582)
5000f92 
* check if get_current_screen exists

* Fix phpcs parens spacing

Co-authored-by: Caspar Green <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCaspar iCaspar iCaspar approved these changes

Assignees

@mostafa-hisham mostafa-hisham

Labels
3rd party compatibility severity: critical type: bug
Projects
None yet
Milestone
1.10
3 participants
@mostafa-hisham @iCaspar @remyperona