Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare original vs optimized image isnot working probably #795

Closed
Mai-Saad opened this issue Feb 2, 2024 · 2 comments · Fixed by #814
Closed

Compare original vs optimized image isnot working probably #795

Mai-Saad opened this issue Feb 2, 2024 · 2 comments · Fixed by #814
Assignees
Labels
priority: medium Issues which are important, but no one will go out of business. severity: minor type: bug
Milestone

Comments

@Mai-Saad
Copy link

Mai-Saad commented Feb 2, 2024

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => 2.1.3.1
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
1- When click compare original vs optimized in the images list, 'Yes' is there beside the optimized size
Screenshot from 2024-02-02 15-28-04
2- When click compare original vs optimized from edit image page, the original and optimized sizes are the same = approximated original size
Screenshot from 2024-02-02 15-30-28

Expected behavior
Size is similar in both views 1,2 where original != optimized size as long as the image is optimized

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

  • Original Size in the backup folder is 41.6K while in the media library list is 40.57K while in 2nd point above is 41K => Will leave this to @wp-media/productimagify to decide if further investigation/GH is needed about that
  • Possible enhancement => here is to make both 1,2 have the same position for 'x'
  • Possible enhancement => decrease the space between file size: value
  • Same on AVIF branch

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@Mai-Saad Mai-Saad added type: bug severity: minor priority: medium Issues which are important, but no one will go out of business. labels Feb 2, 2024
@piotrbak
Copy link

@Mai-Saad Is this a regression in the 2.2 branch?

@Mai-Saad
Copy link
Author

Mai-Saad commented Feb 20, 2024

@piotrbak it's already on 2.1.3.1 version (not related to AVIF)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Issues which are important, but no one will go out of business. severity: minor type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants