Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In media library New image size shall be that of AVIF|webP|optimized based on which exists #794

Closed
Mai-Saad opened this issue Feb 2, 2024 · 1 comment · Fixed by #810
Closed

In media library New image size shall be that of AVIF|webP|optimized based on which exists #794

Mai-Saad opened this issue Feb 2, 2024 · 1 comment · Fixed by #810
Assignees
@Khadreal @Mai-Saad
Labels
AVIF Avif branch/feature priority: medium Issues which are important, but no one will go out of business. severity: major type: bug
Milestone
2.2.1

Comments

@Mai-Saad
Copy link

Mai-Saad commented Feb 2, 2024

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => Avif commit: b396de2
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
The New image size is always the original image optimized size instead of the webP (as on trunk) or the AVIF. After discussion, with @piotrbak , agreed that we shall display the new size as the smallest size

To Reproduce
Steps to reproduce the behavior:

  1. Enable the Avif
  2. upload image
  3. check the image in the media library => compare the new size to that in ftp, it will be the optimized image size, not the AVIF one although AVIF is smaller

Expected behavior
The smaller size of the optimized image shall be displayed in the media library as a new size

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot from 2024-02-02 12-50-19

Additional context
Add any other context about the problem here.

  • on trunk, if create webP is enabled, then we will display the webP size which is < original optimized image size (so sounds like regression on PR)

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

  • New size is always = smallest size version of image , either original optimized, .webP, or .AVIF based on which version is available
@Mai-Saad Mai-Saad added type: bug severity: major priority: high Issues which should be resolved as quickly as possible AVIF Avif branch/feature labels Feb 2, 2024
@piotrbak piotrbak modified the milestone: 2.2 Feb 12, 2024
@Khadreal Khadreal self-assigned this Feb 19, 2024
@Khadreal Khadreal mentioned this issue Feb 21, 2024
Merged
8 tasks
@piotrbak piotrbak added priority: medium Issues which are important, but no one will go out of business. and removed priority: high Issues which should be resolved as quickly as possible labels Feb 29, 2024
@Mai-Saad Mai-Saad self-assigned this Mar 3, 2024
@Mai-Saad Mai-Saad changed the title In media library New image size shall be the smallest size In media library New image size shall be that of AVIF|webP|optimized based on which exists Mar 3, 2024
@piotrbak piotrbak added this to the 2.2.1 milestone Mar 7, 2024
@remyperona remyperona removed this from the 2.2.1 milestone Mar 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 20, 2024
@Khadreal @Miraeld
@jeawhanlee @remyperona @wordpressfan @MathieuLamiot
Closes #794 display the smaller size on image library data (#810)
3b16931 
Co-authored-by: Gaël Robin <[email protected]>
Co-authored-by: Michael Lee <[email protected]>
Co-authored-by: Rémy Perona <[email protected]>
Co-authored-by: Rémy Perona <[email protected]>
Co-authored-by: WordPress Fan <[email protected]>
Co-authored-by: Mathieu Lamiot <[email protected]>
@piotrbak
Copy link

Hey @Tabrisrp Isn't 2.2.1 a correct milestone for this one?

@remyperona remyperona added this to the 2.2.1 milestone Mar 20, 2024
@remyperona remyperona mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khadreal Khadreal

@Mai-Saad Mai-Saad

Labels
AVIF Avif branch/feature priority: medium Issues which are important, but no one will go out of business. severity: major type: bug
Projects
None yet
Milestone
2.2.1
Development

Successfully merging a pull request may close this issue.

Closes #794 display the smaller size on image library data wp-media/imagify-plugin
4 participants
@remyperona @Khadreal @piotrbak @Mai-Saad