FILTER_SANITIZE_STRING deprecation notice with PHP 8.1

[vmanthos]

Before submitting an issue please check that you’ve completed the following steps:

• Made sure you’re on the latest version ✔️
• Used the search feature to ensure that the bug hasn’t been reported before ✔️

Describe the bug

PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /var/www/example.com/htdocs/wp-content/plugins/imagify/inc/classes/class-imagify-views.php on line 511

To Reproduce

Steps to reproduce the behavior:

1. Use PHP 8.1.
2. Activate Imagify.
3. Visit the media library page: /wp-admin/upload.php
4. See the notice in the debug.log.

Expected behavior

No deprecation notices should be there when using Imagify with PHP 8.1.

Additional context

FILTER_SANITIZE_STRING is used in other places in Imagify's code. Those should be tackled as well.

Backlog Grooming (for WP Media dev team use only)

• Reproduce the problem
• Identify the root cause
• Scope a solution
• Estimate the effort

[srsimonson]

similar error also occurs:
Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /var/www/my-path/wp-content/plugins/imagify/inc/classes/class-imagify-views.php on line 511

Same steps to reproduce, except when visiting /wp-admin/edit.php or any other custom post type.

[Mai-Saad]

Can see this error (while AS tables are deleted) , using PHP 8.1 latest and fresh install/activation of imagify (trunk 2.1.1)
[24-May-2023 14:30:55 UTC] PHP Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify-plugin/inc/classes/class-imagify-settings.php on line 134

[vmanthos]

@Tabrisrp I found a couple of issues related to #722:

[22-Jun-2023 09:10:03 UTC] PHP Warning:  Undefined array key "orderby" in /var/www/example.com/htdocs/wp-content/plugins/imagify-plugin/inc/classes/class-imagify-files-list-table.php on line 102
[22-Jun-2023 09:10:03 UTC] PHP Deprecated:  htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/example.com/htdocs/wp-content/plugins/imagify-plugin/inc/classes/class-imagify-files-list-table.php on line 102
[22-Jun-2023 09:10:03 UTC] PHP Warning:  Undefined array key "order" in /var/www/example.com/htdocs/wp-content/plugins/imagify-plugin/inc/classes/class-imagify-files-list-table.php on line 103
[22-Jun-2023 09:10:03 UTC] PHP Deprecated:  htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/example.com/htdocs/wp-content/plugins/imagify-plugin/inc/classes/class-imagify-files-list-table.php on line 103
[22-Jun-2023 09:36:45 UTC] PHP Warning:  Undefined array key "status-filter" in /var/www/example.com/htdocs/wp-content/plugins/imagify-plugin/inc/classes/class-imagify-files-list-table.php on line 1034
[22-Jun-2023 09:36:45 UTC] PHP Deprecated:  htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/example.com/htdocs/wp-content/plugins/imagify-plugin/inc/classes/class-imagify-files-list-table.php on line 1034

To reproduce:

1. With PHP 8.2 visit the MEDIA > Other media page: /wp-admin/upload.php?page=imagify-files
2. Check the debug.log.

Can you please look into these? 🙏

[piotrbak]

@Tabrisrp What do you think it'll be effort for this one?

[alexbogias]

kind reminder