Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Rocket banner is also displayed when WP Rocket is installed but deactivated #586

Closed
4 tasks
piotrbak opened this issue Jul 7, 2021 · 1 comment · Fixed by #631
Closed
4 tasks

WP Rocket banner is also displayed when WP Rocket is installed but deactivated #586

piotrbak opened this issue Jul 7, 2021 · 1 comment · Fixed by #631

Comments

@piotrbak
Copy link

piotrbak commented Jul 7, 2021

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
When WP Rocket is installed but deactivated, we are displaying banner in the Bulk Optimization section. The banner is giving 20% of discount for WP Rocket purchases, not sure if people who already have WP Rocket need it.

To Reproduce
Steps to reproduce the behavior:

  1. Install WP Rocket
  2. Go to Media > Bulk Optimization
  3. See banner

Expected behavior
I think we should display banner only if WP Rocket is not installed

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@GeekPress
Copy link
Contributor

@Mai-Saad FYI, this is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment