Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for rspack and esbuild bundle output #404

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

matzeeable
Copy link
Contributor

@matzeeable matzeeable commented Jun 13, 2024

This is a follow-up to #203 and #204.

In general, the wp i18n make-pot already works with rspack and esbuild and can extract the strings correctly from the generated bundle.

This PR just adds test for both bundlers.

Reference. wp-cli/wp-cli#5955

@matzeeable matzeeable requested a review from a team as a code owner June 13, 2024 09:41
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@swissspidy swissspidy added this to the 2.6.2 milestone Jun 14, 2024
@swissspidy swissspidy merged commit 373ec88 into wp-cli:main Jun 14, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants