Skip to content

Commit

Permalink
VPA: fix bash set options
Browse files Browse the repository at this point in the history
The `set` in `hack/update-kubernetes-deps-in-e2e.sh` contains redundant
options:
* `errexit` equals `-e`
* `nounset` equals `-u`

Also, I have misunderstood how to correctly set options in:
kubernetes#2531

Resource:
https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html
  • Loading branch information
wozniakjan committed Dec 30, 2019
1 parent 9c8e22d commit 45d54eb
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# K8S_TAG - k8s version to use for the dependencies update.
# Suggested format is K8S_TAG=v1.10.3

set -eou errexit pipefail nounset
set -euo pipefail

K8S_TAG=${K8S_TAG:-v1.16.2}
K8S_TAG=${K8S_TAG#v}
Expand Down

0 comments on commit 45d54eb

Please sign in to comment.