Skip to content

Commit

Permalink
feature symfony#5214 [WIP] Reworking most of the registration form: (…
Browse files Browse the repository at this point in the history
…weaverryan)

This PR was merged into the 2.3 branch.

Discussion
----------

[WIP] Reworking most of the registration form:

Hi guys!

| Q             | A
| ------------- | ---
| Doc fix?      | yes (because it's got bad recommendations)
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | --

After trading emails with a user, I realized that we have this very out-dated registration form chapter. Wow :). A summary of the changes:

1) Showing the embedded Registration model is way too hard and unnecessary
2) Stopped persisted plainPassword (why did we do this?)
3) Used AppBundle approach
4) Annotation routing
5) various other small things

This is still a WIP only because I have 2 sections at the bottom I still want to add. Review for what is here now is appreciated.

Honestly, I was a little surprised that entries like this can "hide" in the docs and get so out of date. It's a testament to how big our docs are, but it's a bit of a problem (this is similar to symfony#5184 that had something totally irrelevant in an important doc).

Things to update during merge:
- password encoder
- remove getName() in 2.8
- setDefaultOptions

Thanks!

Commits
-------

a8275a3 Fixing build error
8b7fc79 Tweaks thanks to everyone!
1c1b92a [WIP] Reworking most of the registration form:
  • Loading branch information
weaverryan committed Oct 15, 2015
2 parents 9c555ae + a8275a3 commit 8467240
Show file tree
Hide file tree
Showing 2 changed files with 229 additions and 195 deletions.
Loading

0 comments on commit 8467240

Please sign in to comment.