Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joins should not result in rows if for nil expressions #45

Closed
wotbrew opened this issue Jan 16, 2022 · 1 comment
Closed

joins should not result in rows if for nil expressions #45

wotbrew opened this issue Jan 16, 2022 · 1 comment
Assignees
@wotbrew
Labels
bug Something isn't working
Milestone
0.1.1

Comments

@wotbrew
Copy link
Owner

wotbrew commented Jan 16, 2022

No description provided.

@wotbrew wotbrew added the bug Something isn't working label Jan 16, 2022
@wotbrew wotbrew added this to the 0.1.1 milestone Jan 16, 2022
@wotbrew wotbrew self-assigned this Jan 16, 2022
wotbrew added a commit that referenced this issue Jan 16, 2022
@wotbrew
#45 expressions resulting in nil do not result in joins
6fa3768
wotbrew added a commit that referenced this issue Jan 16, 2022
@wotbrew
#45 use Object sentinel instead of kw
12c30e8 
- concerned we are relying on index details for correctness otherwise, object sentinel guarantees non-eq without any deps
wotbrew added a commit that referenced this issue Jan 16, 2022
@wotbrew
#45 use js/Object sentinel for :cljs
e984fa5
wotbrew added a commit that referenced this issue Jan 16, 2022
@wotbrew
#45 expressions resulting in nil should not be used in joins (#46)
780ab1e 
* #45 expressions resulting in nil do not result in joins

* #45 use Object sentinel instead of kw

- concerned we are relying on index details for correctness otherwise, object sentinel guarantees non-eq without any deps

* #45 use js/Object sentinel for :cljs

* fixed regression for multiarity setops
@wotbrew
Copy link
Owner Author

wotbrew commented Jan 16, 2022

closed by #46

@wotbrew wotbrew closed this as completed Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wotbrew wotbrew

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.1
Development

No branches or pull requests
1 participant
@wotbrew