generated from evan-gray/multichain-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solana: router admin #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingyuyap
force-pushed
the
bing/solana-router-init
branch
6 times, most recently
from
October 2, 2024 03:27
397d1f2
to
2097b45
Compare
bingyuyap
commented
Oct 2, 2024
svm/programs/router/src/instructions/init_integrator_chain_transceivers.rs
Outdated
Show resolved
Hide resolved
bingyuyap
commented
Oct 2, 2024
bingyuyap
commented
Oct 5, 2024
bingyuyap
force-pushed
the
bing/solana-router-init
branch
2 times, most recently
from
October 5, 2024 05:38
2b7f19c
to
ca386e6
Compare
bingyuyap
commented
Oct 5, 2024
svm/programs/router/src/instructions/init_integrator_chain_transceivers.rs
Outdated
Show resolved
Hide resolved
bingyuyap
commented
Oct 5, 2024
bingyuyap
commented
Oct 7, 2024
bingyuyap
commented
Oct 7, 2024
bingyuyap
commented
Oct 7, 2024
bingyuyap
commented
Oct 7, 2024
bingyuyap
commented
Oct 7, 2024
bingyuyap
commented
Oct 7, 2024
bingyuyap
commented
Oct 7, 2024
bingyuyap
commented
Oct 7, 2024
bingyuyap
force-pushed
the
bing/solana-router-init
branch
2 times, most recently
from
October 8, 2024 09:35
dd26119
to
b044a2e
Compare
bingyuyap
commented
Oct 12, 2024
bingyuyap
commented
Oct 12, 2024
bingyuyap
commented
Oct 12, 2024
svm/programs/router/src/instructions/transfer_integrator_config_ownership.rs
Outdated
Show resolved
Hide resolved
bingyuyap
commented
Oct 12, 2024
bingyuyap
force-pushed
the
bing/solana-router-init
branch
from
October 12, 2024 20:46
292d865
to
1b92012
Compare
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
- remove is_immutable and make admin optional - remove has one admin constraint as it is redundant with check_admin - fixed claim admin constraints and added test - fixed typos and other nits alike Signed-off-by: bingyuyap <[email protected]>
- add InvalidChainId for when chain_id = 0 is passed in - check if integrator_chain_config is initialized by checking integrator_chain_config.chain_id == 0 - remove redundant is_some() check - remove redundant update_admin function Signed-off-by: bingyuyap <[email protected]>
evan-gray
force-pushed
the
bing/solana-router-init
branch
from
October 24, 2024 20:28
2a6d8da
to
e9977f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds admin related functionality for the Solana GMP Router:
For more info: check out svm/programs/router/README.md
The table shows the instructions, the specs and also the tests that verifies the specs.
Do not worry,
5,559
lines out of9,206
lines are fromCargo.lock
and2,729
are from tests!Events emission is not included in this PR yet!