Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana: router admin #8

Merged
merged 99 commits into from
Oct 24, 2024
Merged

solana: router admin #8

merged 99 commits into from
Oct 24, 2024

Conversation

bingyuyap
Copy link
Contributor

@bingyuyap bingyuyap commented Sep 25, 2024

This PR adds admin related functionality for the Solana GMP Router:

For more info: check out svm/programs/router/README.md

The table shows the instructions, the specs and also the tests that verifies the specs.

Do not worry, 5,559 lines out of 9,206 lines are from Cargo.lock and 2,729 are from tests!

Events emission is not included in this PR yet!

@bingyuyap bingyuyap force-pushed the bing/solana-router-init branch 6 times, most recently from 397d1f2 to 2097b45 Compare October 2, 2024 03:27
@bingyuyap bingyuyap changed the title Bing/solana router init solana: init router Oct 2, 2024
@bingyuyap bingyuyap marked this pull request as ready for review October 2, 2024 04:41
svm/programs/router/src/error.rs Outdated Show resolved Hide resolved
svm/programs/router/src/state/config.rs Outdated Show resolved Hide resolved
@bingyuyap bingyuyap force-pushed the bing/solana-router-init branch 2 times, most recently from 2b7f19c to ca386e6 Compare October 5, 2024 05:38
@bingyuyap bingyuyap force-pushed the bing/solana-router-init branch 2 times, most recently from dd26119 to b044a2e Compare October 8, 2024 09:35
svm/programs/router/src/lib.rs Outdated Show resolved Hide resolved
svm/programs/router/src/state.rs Outdated Show resolved Hide resolved
svm/programs/router/src/state/integrator_config.rs Outdated Show resolved Hide resolved
svm/programs/router/src/state/registered_transceiver.rs Outdated Show resolved Hide resolved
svm/programs/router/tests/common/execute_transaction.rs Outdated Show resolved Hide resolved
@bingyuyap bingyuyap force-pushed the bing/solana-router-init branch from 292d865 to 1b92012 Compare October 12, 2024 20:46
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
- remove is_immutable and make admin optional
- remove has one admin constraint as it is redundant with check_admin
- fixed claim admin constraints and added test
- fixed typos and other nits alike
Signed-off-by: bingyuyap <[email protected]>
- add InvalidChainId for when chain_id = 0 is passed in
- check if integrator_chain_config is initialized by checking
  integrator_chain_config.chain_id == 0
- remove redundant is_some() check
- remove redundant update_admin function

Signed-off-by: bingyuyap <[email protected]>
@evan-gray evan-gray force-pushed the bing/solana-router-init branch from 2a6d8da to e9977f3 Compare October 24, 2024 20:28
@evan-gray evan-gray merged commit 5455c1d into main Oct 24, 2024
4 checks passed
@evan-gray evan-gray deleted the bing/solana-router-init branch October 24, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants