Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm: add TransceiverRegistry #7

Merged
merged 5 commits into from
Oct 24, 2024
Merged

evm: add TransceiverRegistry #7

merged 5 commits into from
Oct 24, 2024

Conversation

panoel
Copy link
Collaborator

@panoel panoel commented Sep 20, 2024

No description provided.

@panoel panoel force-pushed the transceiver_mgmt branch 2 times, most recently from 2451cc2 to 6d63737 Compare October 1, 2024 15:46
@bruce-riley bruce-riley force-pushed the transceiver_mgmt branch 2 times, most recently from 8c5f238 to d77da03 Compare October 14, 2024 20:55
@panoel panoel force-pushed the transceiver_mgmt branch 2 times, most recently from 3104f58 to 6d4d96a Compare October 15, 2024 22:21
evan-gray
evan-gray requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like most of it is there, just some tweaks.

evm/src/interfaces/ITransceiver.sol Outdated Show resolved Hide resolved
evm/src/interfaces/ITransceiver.sol Outdated Show resolved Hide resolved
evm/src/interfaces/ITransceiver.sol Show resolved Hide resolved
evm/src/Router.sol Outdated Show resolved Hide resolved
evm/src/Router.sol Outdated Show resolved Hide resolved
evm/src/TransceiverRegistry.sol Outdated Show resolved Hide resolved
evm/src/TransceiverRegistry.sol Outdated Show resolved Hide resolved
evm/src/TransceiverRegistry.sol Outdated Show resolved Hide resolved
evm/src/TransceiverRegistry.sol Outdated Show resolved Hide resolved
evm/src/TransceiverRegistry.sol Outdated Show resolved Hide resolved
@bruce-riley bruce-riley mentioned this pull request Oct 18, 2024
Merged
@panoel panoel marked this pull request as ready for review October 22, 2024 14:08
bruce-riley
bruce-riley reviewed Oct 22, 2024
View reviewed changes
evm/src/TransceiverRegistry.sol Outdated Show resolved Hide resolved
evm/src/TransceiverRegistry.sol Outdated Show resolved Hide resolved
evm/src/TransceiverRegistry.sol Outdated Show resolved Hide resolved
evm/src/TransceiverRegistry.sol Show resolved Hide resolved
evm/src/Router.sol Outdated Show resolved Hide resolved
@evan-gray evan-gray requested a review from bruce-riley October 22, 2024 19:34
evan-gray
evan-gray reviewed Oct 22, 2024
View reviewed changes
evm/src/Router.sol Outdated Show resolved Hide resolved
evan-gray
evan-gray reviewed Oct 22, 2024
View reviewed changes
evm/src/Router.sol Outdated Show resolved Hide resolved
evan-gray
evan-gray reviewed Oct 22, 2024
View reviewed changes
evm/src/Router.sol Outdated Show resolved Hide resolved
evan-gray
evan-gray reviewed Oct 22, 2024
View reviewed changes
evm/src/Router.sol Outdated Show resolved Hide resolved
evan-gray
evan-gray reviewed Oct 22, 2024
View reviewed changes
evm/src/Router.sol Outdated Show resolved Hide resolved
evan-gray
evan-gray reviewed Oct 22, 2024
View reviewed changes
evm/src/Router.sol Outdated Show resolved Hide resolved
evan-gray
evan-gray requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only read through router so far but want to get this feedback out.

evan-gray
evan-gray requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, now I think I've reviewed everything but the tests. probably want to revisit public getters, but we can do that in a follow up PR

evan-gray
evan-gray approved these changes Oct 24, 2024
View reviewed changes
evm/src/Router.sol Show resolved Hide resolved
evm/src/Router.sol Show resolved Hide resolved
@panoel panoel merged commit 633b4d9 into main Oct 24, 2024
4 checks passed
@panoel panoel deleted the transceiver_mgmt branch October 24, 2024 20:06
@evan-gray evan-gray added the evm label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruce-riley bruce-riley bruce-riley approved these changes

@evan-gray evan-gray evan-gray approved these changes

@bingyuyap bingyuyap Awaiting requested review from bingyuyap

Assignees
No one assigned
Labels
evm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panoel @evan-gray @bingyuyap @bruce-riley