-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wormchain: integration tests for wormchain-ibc-receiver #4155
Open
kakucodes
wants to merge
39
commits into
wormhole-foundation:main
Choose a base branch
from
kakucodes:feature/integration-test-ibc-receiver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
wormchain: integration tests for wormchain-ibc-receiver #4155
kakucodes
wants to merge
39
commits into
wormhole-foundation:main
from
kakucodes:feature/integration-test-ibc-receiver
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into steve/interchaintest
…kucodes/wormhole into feature/integration-test-ibc-receiver
…egration-test-ibc-receiver
kakucodes
requested review from
nik-suri,
johnsaigle and
mdulin2
as code owners
November 21, 2024 17:20
kakucodes
changed the title
Feature/integration test ibc receiver
wormchain: integration tests for wormchain-ibc-receiver
Nov 21, 2024
joelsmith-2019
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marc and I spent time today walking through all of the code changes & tests. Everything looked good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Integration Tests for IBC Contracts
Overview
This PR implements comprehensive integration tests for
wormchain-ibc-receiver
andwormhole-ibc
contracts using Interchain test framework, providing a realistic testing environment for IBC functionality.Key Changes
Technical Details
Testing
Tests cover:
Dependencies
Impact
These tests significantly improve our confidence in the IBC contracts by: