Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/js: Add deprecated warning to README #4091

Closed
wants to merge 2 commits into from

Conversation

kev1n-peters
Copy link
Contributor

No description provided.

evan-gray
evan-gray previously approved these changes Aug 21, 2024
panoel
panoel previously approved these changes Aug 21, 2024
artursapek
artursapek previously approved these changes Aug 21, 2024
@kev1n-peters kev1n-peters marked this pull request as draft August 21, 2024 15:38
@kev1n-peters
Copy link
Contributor Author

Waiting to deprecate until this is merged: wormhole-foundation/wormhole-sdk-ts#602

sdk/js/README.md Outdated

> Note: This is a pre-alpha release and in active development. Function names and signatures are subject to change.
**⚠️ This SDK is deprecated. Please use the new SDK available at [wormhole-sdk-ts](https://github.com/wormhole-foundation/wormhole-sdk-ts).**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend linking to NPM instead as most users would be looking at this via npmjs.org:

Please use the new SDK available at [@wormhole-foundation/sdk](https://www.npmjs.com/package/@wormhole-foundation/sdk).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@kev1n-peters kev1n-peters dismissed stale reviews from artursapek, panoel, and evan-gray via 4b55f37 September 6, 2024 15:39
@kev1n-peters kev1n-peters requested a review from tonyjin September 6, 2024 15:39
@kev1n-peters kev1n-peters marked this pull request as ready for review September 6, 2024 15:39
@kev1n-peters kev1n-peters force-pushed the deprecate-certusone-sdk-readme branch 2 times, most recently from 314f588 to 4004fe7 Compare September 6, 2024 15:40
@kev1n-peters kev1n-peters force-pushed the deprecate-certusone-sdk-readme branch from 4004fe7 to cbcfee8 Compare September 6, 2024 15:40
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evan-gray evan-gray requested a review from artursapek September 6, 2024 17:06
@tonyjin
Copy link
Contributor

tonyjin commented Oct 23, 2024

Closed in favor of #4142

@tonyjin tonyjin closed this Oct 23, 2024
@tonyjin tonyjin deleted the deprecate-certusone-sdk-readme branch October 23, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants