Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm urls for tools, fix skip_preflight variable #210

Closed
wants to merge 1 commit into from

Conversation

mnguyen-io
Copy link
Contributor

@mnguyen-io mnguyen-io commented Jul 15, 2021

change

request.skip_preflight to request.get_ref().skip_preflight

Previously this would return:

error[E0609]: no field `skip_preflight` on type `tonic::Request<SubmitVaaRequest>`
  --> agent/src/main.rs:95:72
   |
95 |                 match sign_and_send(&rpc, &mut tx, vec![&key], request.skip_preflight) {
   |                                                                        ^^^^^^^^^^^^^^ unknown field
   |
help: one of the expressions' fields has a field of the same name
   |
95 |                 match sign_and_send(&rpc, &mut tx, vec![&key], request.message.skip_preflight) {
   |                                                                        ^^^^^^^^
error[E0609]: no field `skip_preflight` on type `tonic::Request<SubmitVaaRequest>`
   --> agent/src/main.rs:107:78
    |
107 |             match sign_and_send(&rpc, &mut transaction2, vec![&key], request.skip_preflight) {
    |                                                                              ^^^^^^^^^^^^^^ unknown field
    |
help: one of the expressions' fields has a field of the same name
    |
107 |             match sign_and_send(&rpc, &mut transaction2, vec![&key], request.message.skip_preflight) {
    |                                                                              ^^^^^^^^
error: aborting due to 2 previous errors; 7 warnings emitted
For more information about this error, try `rustc --explain E0609`.
error: could not compile `agent`
To learn more, run the command again with --verbose.
make: *** [Makefile:41: build/bin/guardiand-solana-agent] Error 101

npm urls in tools/package-lock.json causing the following errors:

npm ERR! code ENOTFOUND
npm ERR! syscall getaddrinfo
npm ERR! errno ENOTFOUND
npm ERR! network request to https://npm/ts-proto-descriptors/-/ts-proto-descriptors-1.2.1.tgz failed, reason: getaddrinfo ENOTFOUND npm
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network 
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

Updated to use https://registry.npmjs.org/..


This change is Reviewable

leoluk pushed a commit that referenced this pull request Jul 16, 2021
Closes #210

Change-Id: Ideea67b2269a59a76c65745df224b7d006cd2010
@leoluk
Copy link
Contributor

leoluk commented Jul 18, 2021

GitHub is confused, PR is merged via Gerrit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants