Leverage wormscan client on sourcetx middleware #214
Conversation
mat1asm
changed the base branch from
missed-vaas-list-look-ahead-prepare
to
main
| await sleep((attempt + 1) * 200); // linear wait | ||
| } | ||
| } while (++attempt < retries && !txHash); | ||
| let txHash = response.data?.txHash || ""; |
There was a problem hiding this comment.
May be we can throw an error if we don't find txHash on the response data object and remove empty string as fallback.
There was a problem hiding this comment.
Maybe we should put a comment somewhere (or ideally on documentation if we had any), but...
It's a design decision not to throw an error. This is becase you wan't to leave this decision to the user of relayer-engine. The source tx hash is strictly necessary for processing some VAAs, but not for others, so it's up to the user to decide.
At some point we thought that maybe we can make this a configuration of the middleware but never got to implement it... for the time been I'd leave it as is
|
Appreciate that you went the extra mile and implemented this 🖤 |
mat1asm
force-pushed
the
change-sourcetx-client
branch
from
90a89f1 to
5a44a0f
Compare
mat1asm
force-pushed
the
change-sourcetx-client
branch
from
5a44a0f to
baa27b3
Compare
No description provided.