Fix: Syncing #25
Merged
Fix: Syncing #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eqwest http client
Dzejkop
reviewed
Nov 2, 2023
| @@ -6,5 +6,7 @@ abigen!( | |||
| event TreeChanged(uint256 indexed preRoot, uint8 indexed kind, uint256 indexed postRoot) | |||
| function registerIdentities(uint256[8] calldata insertionProof, uint256 preRoot, uint32 startIndex, uint256[] calldata identityCommitments, uint256 postRoot) external | |||
| function deleteIdentities(uint256[8] calldata deletionProof, bytes calldata packedDeletionIndices, uint256 preRoot, uint256 postRoot) external | |||
| function deleteIdentities(uint256[8] calldata deletionProof, uint32 batchSize, bytes calldata packedDeletionIndices, uint256 preRoot, uint256 postRoot) external | |||
There was a problem hiding this comment.
Kinda sucks for staging but on prod we won't have this at all. Maybe we should instead allow manually adding some events via some config file at specific blocks?
So for staging we could manually add the deletions with batchSize - but it could also prove useful for testing imo.
Dzejkop
reviewed
Nov 2, 2023
Dzejkop
reviewed
Nov 2, 2023
Dzejkop
reviewed
Nov 2, 2023
Dzejkop
reviewed
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed syncing logic to ignore padded values.