Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #5

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Update README.md #5

merged 2 commits into from
Dec 19, 2023

Conversation

eltociear
Copy link
Contributor

Update README.md

PR description

dependecies -> dependencies

Type

  • Feature
  • Refactoring
  • Bugfix
  • DevOps
  • Testing

Checklist

  • I've made sure that my code works as expected by writting unit tests.
  • I've checked if my code doesn't generate warnings or errors.
  • I've performed a self-review of my code.
  • I've made sure that my code follows the style guidelines of the project.
  • I've commented hard-to-understand parts of my code.
  • I've made appropriate changes in the documentation.

TanguyJeanneau and others added 2 commits December 14, 2023 13:11
dependecies -> dependencies
@eltociear eltociear requested a review from a team as a code owner December 18, 2023 16:00
@TanguyJeanneau TanguyJeanneau changed the base branch from main to dev December 18, 2023 19:12
Copy link
Contributor

@TanguyJeanneau TanguyJeanneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eltociear , thanks for the fix ! 🙇

I've modified the base branch from main to dev, as our workflow is your_branch -> dev -> main. I will update the default branch accordingly and modify the contribution guidelines to highlight this.

This does not changes the status on your PR, ready to merge !

@TanguyJeanneau TanguyJeanneau merged commit 8c79fd7 into worldcoin:dev Dec 19, 2023
3 checks passed
@TanguyJeanneau TanguyJeanneau mentioned this pull request Jun 17, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants