Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yi update performance card #4

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Yi update performance card #4

merged 2 commits into from
Dec 15, 2023

Conversation

ycbiometrics
Copy link
Contributor

@ycbiometrics ycbiometrics commented Dec 14, 2023 •
edited by wiktorlazarski
Loading

Update performance card

PR description

Update to the performance card with updated figures 1(a), 1(b) and added some wording in last section.

Type

  • Feature
  • Refactoring
  • Bugfix
  • DevOps
  • Testing

Checklist

  • I've made sure that my code works as expected by writting unit tests.
  • I've checked if my code doesn't generate warnings or errors.
  • I've performed a self-review of my code.
  • I've made sure that my code follows the style guidelines of the project.
  • I've commented hard-to-understand parts of my code.
  • I've made appropriate changes in the documentation.

@ycbiometrics ycbiometrics requested a review from a team as a code owner December 14, 2023 18:58
@wiktorlazarski wiktorlazarski changed the base branch from main to dev December 15, 2023 11:03
wiktorlazarski
wiktorlazarski approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@wiktorlazarski wiktorlazarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🔥!

@ycbiometrics ycbiometrics merged commit 9c64150 into dev Dec 15, 2023
3 checks passed
@ycbiometrics ycbiometrics deleted the yi-update_performance_card branch December 15, 2023 13:57
@TanguyJeanneau TanguyJeanneau mentioned this pull request Jun 17, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorlazarski wiktorlazarski wiktorlazarski approved these changes

@TanguyJeanneau TanguyJeanneau Awaiting requested review from TanguyJeanneau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ycbiometrics @wiktorlazarski