Consolidate GitHub Environment variables. #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdomen-ggl
approved these changes
May 11, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
SanjayVas
force-pushed
the
sanjayvas-terraform-workflow
branch
from
e3467bf to
5de992a
Compare
SanjayVas
force-pushed
the
sanjayvas-env-vars
branch
from
820f938 to
5a87676
Compare
stevenwarejones
approved these changes
May 12, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:
SanjayVas
force-pushed
the
sanjayvas-terraform-workflow
branch
from
5de992a to
f6a89e9
Compare
SanjayVas
force-pushed
the
sanjayvas-env-vars
branch
from
5a87676 to
54fd926
Compare
SanjayVas
force-pushed
the
sanjayvas-terraform-workflow
branch
from
f6a89e9 to
d52ca38
Compare
SanjayVas
force-pushed
the
sanjayvas-env-vars
branch
from
54fd926 to
4eb42f3
Compare
SanjayVas
force-pushed
the
sanjayvas-terraform-workflow
branch
from
d52ca38 to
6a240af
Compare
SanjayVas
force-pushed
the
sanjayvas-env-vars
branch
from
4eb42f3 to
01cf7a1
Compare
SanjayVas
force-pushed
the
sanjayvas-terraform-workflow
branch
from
6a240af to
ba8a39a
Compare
SanjayVas
force-pushed
the
sanjayvas-env-vars
branch
from
01cf7a1 to
1190131
Compare
SanjayVas
force-pushed
the
sanjayvas-terraform-workflow
branch
from
ba8a39a to
c8b1db0
Compare
SanjayVas
force-pushed
the
sanjayvas-env-vars
branch
from
1190131 to
027c00f
Compare
SanjayVas
force-pushed
the
sanjayvas-env-vars
branch
from
027c00f to
0efb1bc
Compare
The following variables can be removed: * DUCHY_STORAGE_BUCKET * SIMULATOR_STORAGE_BUCKET * REPORTING_CLUSTER_LOCATION * POSTGRES_REGION
SanjayVas
force-pushed
the
sanjayvas-env-vars
branch
2 times, most recently
from
72ad3d7 to
68fb347
Compare
SanjayVas
force-pushed
the
sanjayvas-env-vars
branch
2 times, most recently
from
72ad3d7 to
1decfa9
Compare
SanjayVas
commented
May 16, 2023
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following variables can be removed: