Fix always-true conditional check in SpannerDataProviderService

[Marco-Premier]

No description provided.

[wfa-reviewable]

This change is 

[tristanvuong2021]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jojijac0b, @Marco-Premier, and @SanjayVas)

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/SpannerDataProvidersService.kt line 57 at r1 (raw file):

    request: ReplaceDataProviderRequiredDuchiesRequest
  ): DataProvider {
    grpcRequire(request.externalDataProviderId > 0L) { "externalDataProviderId field is missing." }

Should be != in case in the future we want to allow negatives and this wouldn't silently break.

[Marco-Premier]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jojijac0b, @SanjayVas, and @tristanvuong2021)

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/SpannerDataProvidersService.kt line 57 at r1 (raw file):

Previously, tristanvuong2021 (Tristan Vuong) wrote…

Should be != in case in the future we want to allow negatives and this wouldn't silently break.

That's interesting, thanks

[tristanvuong2021]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jojijac0b and @SanjayVas)

[SanjayVas]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jojijac0b)