Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new build targets for release workflows. #965

Merged
merged 1 commit into from
May 2, 2023

Conversation

SanjayVas
Copy link
Member

  • //src/main/docker:push_all_gke_images target for push image workflow
  • Kustomize-based targets for K8s workflows.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas
Copy link
Member Author

Depends on #948

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-dev-cmms branch from 5e6fac8 to b3fad85 Compare April 25, 2023 17:59
@SanjayVas SanjayVas force-pushed the sanjayvas-release-workflow branch 2 times, most recently from 1a14f7d to 69d405b Compare April 26, 2023 00:44
@SanjayVas SanjayVas temporarily deployed to dev April 26, 2023 00:44 — with GitHub Actions Inactive
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


.github/workflows/configure-kingdom.yml line 110 at r2 (raw file):

        uses: google-github-actions/get-gke-credentials@v1
        with:
          cluster_name: kingdom

you want this fixed?

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)


.github/workflows/configure-kingdom.yml line 110 at r2 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

you want this fixed?

It simplifies things to have the cluster names be static. We don't plan to put more than one Kingdom cluster in the QA/nightly cloud projects. I just recreated the cluster in halo-cmm-dev to match this name.

This is consistent with how we use static cluster names for the Duchies as well (worker1_duchy, worker2_duchy, aggregator_duchy).

@SanjayVas SanjayVas force-pushed the sanjayvas-release-workflow branch 2 times, most recently from 887e9fb to c93ced8 Compare April 26, 2023 19:24
@SanjayVas SanjayVas force-pushed the sanjayvas-dev-cmms branch from 0811daa to 40f368b Compare April 26, 2023 19:24
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-dev-cmms branch from 40f368b to 64a9f15 Compare April 26, 2023 19:39
@SanjayVas SanjayVas force-pushed the sanjayvas-release-workflow branch from c93ced8 to 4f258a3 Compare April 26, 2023 19:39
@SanjayVas SanjayVas force-pushed the sanjayvas-dev-cmms branch from 64a9f15 to 9dc7905 Compare April 27, 2023 23:34
@SanjayVas SanjayVas force-pushed the sanjayvas-release-workflow branch 2 times, most recently from cfa7c11 to fb48a38 Compare May 2, 2023 16:18
@SanjayVas SanjayVas temporarily deployed to dev May 2, 2023 16:56 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev May 2, 2023 17:04 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev May 2, 2023 17:07 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev May 2, 2023 17:07 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev May 2, 2023 20:12 — with GitHub Actions Inactive
Base automatically changed from sanjayvas-dev-cmms to main May 2, 2023 21:02
* //src/main/docker:push_all_gke_images target for push image workflow
* Kustomize-based targets for K8s workflows.
@SanjayVas SanjayVas force-pushed the sanjayvas-release-workflow branch from fb48a38 to d945ceb Compare May 2, 2023 21:21
@SanjayVas SanjayVas enabled auto-merge (squash) May 2, 2023 21:23
@SanjayVas SanjayVas merged commit f40536f into main May 2, 2023
@SanjayVas SanjayVas deleted the sanjayvas-release-workflow branch May 2, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants