-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new build targets for release workflows. #965
Conversation
SanjayVas
commented
Apr 24, 2023
- //src/main/docker:push_all_gke_images target for push image workflow
- Kustomize-based targets for K8s workflows.
Depends on #948 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
5e6fac8
to
b3fad85
Compare
1a14f7d
to
69d405b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
.github/workflows/configure-kingdom.yml
line 110 at r2 (raw file):
uses: google-github-actions/get-gke-credentials@v1 with: cluster_name: kingdom
you want this fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
.github/workflows/configure-kingdom.yml
line 110 at r2 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
you want this fixed?
It simplifies things to have the cluster names be static. We don't plan to put more than one Kingdom cluster in the QA/nightly cloud projects. I just recreated the cluster in halo-cmm-dev to match this name.
This is consistent with how we use static cluster names for the Duchies as well (worker1_duchy, worker2_duchy, aggregator_duchy).
887e9fb
to
c93ced8
Compare
0811daa
to
40f368b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
40f368b
to
64a9f15
Compare
c93ced8
to
4f258a3
Compare
64a9f15
to
9dc7905
Compare
cfa7c11
to
fb48a38
Compare
* //src/main/docker:push_all_gke_images target for push image workflow * Kustomize-based targets for K8s workflows.
fb48a38
to
d945ceb
Compare