-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Address lint errors. #1972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @kungfucraig)
src/main/proto/wfa/measurement/reporting/v2alpha/event_group.proto
line 40 at r1 (raw file):
string name = 1 [ (google.api.field_behavior) = IDENTIFIER, (google.api.field_behavior) = IMMUTABLE
Just IDENTIFIER for the name
field. It implies a subtly different definition of immutability than IMMUTABLE. See https://google.aip.dev/203#identifier
src/main/proto/wfa/measurement/reporting/v2alpha/reporting_sets_service.proto
line 115 at r1 (raw file):
} // Request message for 'GetReportingSetRequeest' method.
Suggestion:
GetReportingSet
08944e4
to
4263417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 9 files reviewed, 2 unresolved discussions (waiting on @SanjayVas)
src/main/proto/wfa/measurement/reporting/v2alpha/event_group.proto
line 40 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Just IDENTIFIER for the
name
field. It implies a subtly different definition of immutability than IMMUTABLE. See https://google.aip.dev/203#identifier
Done.
src/main/proto/wfa/measurement/reporting/v2alpha/reporting_sets_service.proto
line 115 at r1 (raw file):
} // Request message for 'GetReportingSetRequeest' method.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @stevenwarejones)
src/main/proto/wfa/measurement/reporting/v2alpha/reporting_sets_service.proto
line 115 at r1 (raw file):
Previously, kungfucraig (Craig Wright) wrote…
Done.
Not quite. You have
// Request message for 'GetReportingSetRequest' method.
instead of
// Request message for `GetReportingSet` method.
The method name is incorrect and the comment is using single quotes instead of backticks for the symbol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @SanjayVas and @stevenwarejones)
src/main/proto/wfa/measurement/reporting/v2alpha/reporting_sets_service.proto
line 115 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Not quite. You have
// Request message for 'GetReportingSetRequest' method.
instead of
// Request message for `GetReportingSet` method.
The method name is incorrect and the comment is using single quotes instead of backticks for the symbol.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 7 of 8 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @kungfucraig)
2db9897
to
be81181
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 7 of 8 files at r2, 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @kungfucraig)
No description provided.