fix: Remove if check for update time filters when adding shard ID clause in StreamMeasurements #1901
Conversation
|
This change is |
There was a problem hiding this comment.
StreamMeasurements always orders results by Update time
This is the important part, meaning the index is always used. Is this resulting in any buggy behavior, or just a performance hit?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
There was a problem hiding this comment.
I didn't look into it closely, but it is giving me no results.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
tristanvuong2021
deleted the
tristanvuong-remove-update-time-check-in-stream-measurements-for-shard
branch
…use in StreamMeasurements (#1901) fix: Remove if check for update time filters when adding shard ID clause in StreamMeasurements StreamMeasurements always orders results by Update time so the shard ID clause should always be added.
fix: Remove if check for update time filters when adding shard ID clause in StreamMeasurements
StreamMeasurements always orders results by Update time so the shard ID clause should always be added. Testing revealed that with the if check, setting the after field is required for it to work properly.