-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new view for retrieving additional log entries #1889
feat: Add new view for retrieving additional log entries #1889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
src/main/proto/wfa/measurement/internal/kingdom/measurement.proto
line 44 at r1 (raw file):
// and additional log entries for ComputationParticipants, but does not // include child Requisitions. COMPUTATION_ALTERNATIVE = 2;
Let's get a better name for this that actually describes what it is rather than just "alternative".
Maybe COMPUTATION_STATS
? COMPUTATION_AUDIT
?
Code quote:
COMPUTATION_ALTERNATIVE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/proto/wfa/measurement/internal/kingdom/measurement.proto
line 44 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Let's get a better name for this that actually describes what it is rather than just "alternative".
Maybe
COMPUTATION_STATS
?COMPUTATION_AUDIT
?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
feat: Add new view for retrieving additional log entries
Supports #1805