Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new view for retrieving additional log entries #1889

Conversation

tristanvuong2021
Copy link
Contributor

feat: Add new view for retrieving additional log entries

Supports #1805

@wfa-reviewable
Copy link

This change is Reviewable

@tristanvuong2021 tristanvuong2021 marked this pull request as ready for review October 30, 2024 19:36
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)


src/main/proto/wfa/measurement/internal/kingdom/measurement.proto line 44 at r1 (raw file):

    // and additional log entries for ComputationParticipants, but does not
    // include child Requisitions.
    COMPUTATION_ALTERNATIVE = 2;

Let's get a better name for this that actually describes what it is rather than just "alternative".

Maybe COMPUTATION_STATS? COMPUTATION_AUDIT?

Code quote:

COMPUTATION_ALTERNATIVE

Copy link
Contributor Author

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/proto/wfa/measurement/internal/kingdom/measurement.proto line 44 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Let's get a better name for this that actually describes what it is rather than just "alternative".

Maybe COMPUTATION_STATS? COMPUTATION_AUDIT?

Done.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 6 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

@tristanvuong2021 tristanvuong2021 merged commit 4535a58 into main Nov 1, 2024
4 checks passed
@tristanvuong2021 tristanvuong2021 deleted the tristanvuong-add-measurement-view-for-additional-log-entries branch November 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants