-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Keep Trivy cache up-to-date on default branch #1878
Conversation
0e9bd6c
to
124da42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
.github/workflows/scan-images.yml
line 99 at r1 (raw file):
uses: aquasecurity/[email protected] env: TRIVY_SKIP_DB_UPDATE: true
why would we skip updating the vulnerability db?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
.github/workflows/scan-images.yml
line 99 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
why would we skip updating the vulnerability db?
The idea is to use the cached versions rather than having the Trivy application attempt to download the DBs. The link in the PR description explains this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
124da42
to
3df831c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @stevenwarejones from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
See https://github.com/aquasecurity/trivy-action?tab=readme-ov-file#updating-caches-in-the-default-branch