-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Ensure that MeasurementIndexShardId is non-negative #1863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
Statements to roll back previous schema change: DROP INDEX MeasurementsByContinuationToken;
ALTER TABLE Measurements
DROP COLUMN MeasurementIndexShardId;
CREATE INDEX MeasurementsByContinuationToken ON Measurements(
UpdateTime,
ExternalComputationId,
State
);
DELETE FROM DATABASECHANGELOG
WHERE
id = '21'
AND author = 'sanjayvas'
AND filename = 'kingdom/spanner/shard-measurements-by-continuation-token.sql'; I've already run this on halo-cmm-head and halo-cmm-qa. It will need to be re-run if the bad schema update is re-applied, e.g. by the Kingdom internal server restarting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
BREAKING CHANGE: This is updating an existing Liquibase changeset, and will therefore require manual adjustments wherever it has been rolled out. This should only have rolled out to Halo test environments.
dd04650
to
902de1c
Compare
I re-ran the statements on halo-cmm-head as it had gotten redeployed without this change. |
BREAKING CHANGE: This is updating an existing Liquibase changeset, and will therefore require manual adjustments wherever it has been rolled out. This should only have rolled out to Halo test environments.
Closes #1862