feat: ControlPlane initial proto definitions. #1843

Marco-Premier · 2024-10-09T16:23:24Z

No description provided.

wfa-reviewable · 2024-10-09T16:23:32Z

This change is

stevenwarejones

Needs a bazel build

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @Marco-Premier, and @SanjayVas)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 21 at r1 (raw file):

import "google/protobuf/any.proto";

option java_package = "org.wfanet.controlplane";

wdyt about org.wfanet.securecomputation ?

SanjayVas

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 5 unresolved discussions (waiting on @kungfucraig, @Marco-Premier, and @stevenwarejones)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 1 at r1 (raw file):

// Copyright 2024 The Cross-Media Measurement Authors

Follow existing directory structure. This is a Halo component, meaning it's a sibling to the Kingdom or Duchy. (The "top-level" part of "new top-level directory" meant under "measurement", as that's the Halo root).

Note that I think that panelmatch should have been under measurement as well. The wfa package is for the WFA in general, and the measurement subpackage of that is for Halo.

As an aside, if we were to start again we'd probably have Halo be the root package as we ended up getting the Halo name and halo-cmm.org domain later on.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 17 at r1 (raw file):

syntax = "proto3";

package wfa.controlplane;

This is a public API that must follow the AIPs. Therefore it must be versioned, so there should be a v1alpha leaf package.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 26 at r1 (raw file):

message WorkItem {
    option (google.api.resource) = {
        type: "halo.wfanet.org/WorkItem"

Use the new halo-cmm.org domain like how we do in the Reporting API. The subdomain identifies the API.

We could also add an additional subdomain for confidential-computing if we'll have more APIs underneath it, e.g. control-plane.confidential-computing.halo-cmm.org.

Suggestion:

control-plane.halo-cmm.org/WorkItem

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

    // The queue identifier into which this `WorkItem` must be enqueued.
    // Available queue identifiers are specified in a configuration file.
    string queue_identifier = 2;

Queues should be their own resource type so that this can be a resource reference. It's just that it's a resource type without a Create method, as it comes purely from configuration.

Marco-Premier

Reviewable status: 0 of 4 files reviewed, 5 unresolved discussions (waiting on @kungfucraig, @SanjayVas, and @stevenwarejones)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 1 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Follow existing directory structure. This is a Halo component, meaning it's a sibling to the Kingdom or Duchy. (The "top-level" part of "new top-level directory" meant under "measurement", as that's the Halo root).

Note that I think that panelmatch should have been under measurement as well. The wfa package is for the WFA in general, and the measurement subpackage of that is for Halo.

As an aside, if we were to start again we'd probably have Halo be the root package as we ended up getting the Halo name and halo-cmm.org domain later on.

I'm not sure I follow @SanjayVas , are you suggesting to put thi proto definitions under this package:
https://github.com/world-federation-of-advertisers/cross-media-measurement/tree/main/src/main/proto/wfa/measurement?

If that's the case I thought we agreed to have a mono-repo but with dedicated folder for all secure computation related code?

What are your thoughts @stevenwarejones ?

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 17 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

This is a public API that must follow the AIPs. Therefore it must be versioned, so there should be a v1alpha leaf package.

Done.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 21 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

wdyt about org.wfanet.securecomputation ?

I used org.wfanet.securecomputation.controlplane.v1alpha because I thought that we may have other sub-packages under securecomputation in future?

Let me know what you think

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 26 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Use the new halo-cmm.org domain like how we do in the Reporting API. The subdomain identifies the API.

We could also add an additional subdomain for confidential-computing if we'll have more APIs underneath it, e.g. control-plane.confidential-computing.halo-cmm.org.

Done.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Queues should be their own resource type so that this can be a resource reference. It's just that it's a resource type without a Create method, as it comes purely from configuration.

Done.

stevenwarejones

Reviewable status: 0 of 4 files reviewed, 5 unresolved discussions (waiting on @kungfucraig and @SanjayVas)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 1 at r1 (raw file):

Previously, Marco-Premier (marcopremier) wrote…

I'm not sure I follow @SanjayVas , are you suggesting to put thi proto definitions under this package:
https://github.com/world-federation-of-advertisers/cross-media-measurement/tree/main/src/main/proto/wfa/measurement?

If that's the case I thought we agreed to have a mono-repo but with dedicated folder for all secure computation related code?

What are your thoughts @stevenwarejones ?

One issue is that we don't want the control plane and the TEE SDK to consume anything other than common.

Both @Marco-Premier and I had understood @kungfucraig 's comment to be a top-level folder similar to what Marco has.

I think there's a couple good reason to put it in a separate top level folder:

We don't want it to consume any-sketch or vid-labeling.... stuff in this folder https://github.com/world-federation-of-advertisers/cross-media-measurement/tree/main/src/main/proto/wfa which is not even under measurement.
Its completely separate from Measurement and arguably it can be used for non-measurement Halo use cases.

kungfucraig

Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 7 unresolved discussions (waiting on @Marco-Premier, @SanjayVas, and @stevenwarejones)

secure_computation/control_plane/src/main/proto/wfa/controlplane/v1alpha/queue.proto line 17 at r2 (raw file):

syntax = "proto3";

package wfa.controlplane.v1alpha;

Can you update the proto package and directory to be a mirror of whatever the java package is? (i.e. wfa/securecomput[e|ation]/controlplane/v1alpha/...)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 21 at r1 (raw file):

Previously, Marco-Premier (marcopremier) wrote…

I used org.wfanet.securecomputation.controlplane.v1alpha because I thought that we may have other sub-packages under securecomputation in future?

Let me know what you think

I like org.wfanet.securecomputation.controlplane.v1alpha

If you want to shorten it, s/securecomputation/securecompute

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 26 at r1 (raw file):

Previously, Marco-Premier (marcopremier) wrote…

Done.

Can we drop the hyphens from the subdomains, or is that the convention we've already adopted?

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

Previously, Marco-Premier (marcopremier) wrote…

Done.

Per https://google.aip.dev/122

I think you want this to be "string queue = 2;"

secure_computation/control_plane/src/main/proto/wfa/controlplane/v1alpha/work_items_service.proto line 1 at r2 (raw file):

// Copyright 2021 The Cross-Media Measurement Authors

2024

SanjayVas

Reviewable status: 0 of 4 files reviewed, 7 unresolved discussions (waiting on @kungfucraig, @Marco-Premier, and @stevenwarejones)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 1 at r1 (raw file):

Both @Marco-Premier and I had understood @kungfucraig 's comment to be a top-level folder similar to what Marco has.

This was clearly a misunderstanding. Nothing should have a separate folder at the root of the repo, only at the root Halo package.

We don't want it to consume any-sketch or vid-labeling.... stuff in this folder https://github.com/world-federation-of-advertisers/cross-media-measurement/tree/main/src/main/proto/wfa which is not even under measurement.

There's no reason that being a sibling to other Halo components implies that this would depend on or be used by those other component packages.

Its completely separate from Measurement and arguably it can be used for non-measurement Halo use cases.

There's no such thing as a non-measurement Halo use case. The whole Halo project is for measurement in general. The full name of Halo is "Halo Cross-Media Measurement", hence why this repo is named cross-media-measurement and the domain is halo-cmm.org. As I stated above, the intent was that the measurement package means Halo, where the parent wfa package means all of the WFA. This is why I'm stating that e.g. panelmatch is also at the wrong level and should have been under measurement.

SanjayVas

Reviewable status: 0 of 4 files reviewed, 6 unresolved discussions (waiting on @kungfucraig, @Marco-Premier, and @stevenwarejones)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 1 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Both @Marco-Premier and I had understood @kungfucraig 's comment to be a top-level folder similar to what Marco has.

This was clearly a misunderstanding. Nothing should have a separate folder at the root of the repo, only at the root Halo package.

We don't want it to consume any-sketch or vid-labeling.... stuff in this folder https://github.com/world-federation-of-advertisers/cross-media-measurement/tree/main/src/main/proto/wfa which is not even under measurement.

There's no reason that being a sibling to other Halo components implies that this would depend on or be used by those other component packages.

Its completely separate from Measurement and arguably it can be used for non-measurement Halo use cases.

There's no such thing as a non-measurement Halo use case. The whole Halo project is for measurement in general. The full name of Halo is "Halo Cross-Media Measurement", hence why this repo is named cross-media-measurement and the domain is halo-cmm.org. As I stated above, the intent was that the measurement package means Halo, where the parent wfa package means all of the WFA. This is why I'm stating that e.g. panelmatch is also at the wrong level and should have been under measurement.

I think you may be conflating the measurement package as being for the CMMS/PRFE as opposed to all of Halo in general.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 26 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Can we drop the hyphens from the subdomains, or is that the convention we've already adopted?

We've yet to have a subdomain with a hyphen, so no real convention there. It's just that the domain has a hyphen, so I figured we'd continue that for subdomains. I have no strong opinion either way.

stevenwarejones

Reviewable status: 0 of 4 files reviewed, 6 unresolved discussions (waiting on @kungfucraig, @Marco-Premier, and @SanjayVas)

secure_computation/control_plane/src/main/proto/wfa/controlplane/v1alpha/work_items_service.proto line 17 at r2 (raw file):

syntax = "proto3";

package wfa.controlplane.v1alpha;

ditto on craig's comment about the package namespace

Marco-Premier

Reviewable status: 0 of 4 files reviewed, 6 unresolved discussions (waiting on @kungfucraig, @SanjayVas, and @stevenwarejones)

secure_computation/control_plane/src/main/proto/wfa/controlplane/v1alpha/queue.proto line 17 at r2 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Can you update the proto package and directory to be a mirror of whatever the java package is? (i.e. wfa/securecomput[e|ation]/controlplane/v1alpha/...)

Done.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 1 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

I think you may be conflating the measurement package as being for the CMMS/PRFE as opposed to all of Halo in general.

Done.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Per https://google.aip.dev/122

I think you want this to be "string queue = 2;"

Done.

secure_computation/control_plane/src/main/proto/wfa/controlplane/v1alpha/work_items_service.proto line 1 at r2 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

2024

Done.

secure_computation/control_plane/src/main/proto/wfa/controlplane/v1alpha/work_items_service.proto line 17 at r2 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

ditto on craig's comment about the package namespace

Done.

kungfucraig

Please drop the underscores from the package/directory names to match conventions in the rest of the repo.

Reviewed 1 of 4 files at r2, 1 of 4 files at r3, all commit messages.
Reviewable status: 1 of 4 files reviewed, 6 unresolved discussions (waiting on @Marco-Premier, @SanjayVas, and @stevenwarejones)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 17 at r1 (raw file):

Previously, Marco-Premier (marcopremier) wrote…

Done.

wfa.measurement.securecomputation.controlplane ?

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 21 at r1 (raw file):

import "google/protobuf/any.proto";

option java_package = "org.wfanet.controlplane";

Same as above.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

Previously, Marco-Premier (marcopremier) wrote…

Done.

I think the AIP wants this to be called just "queue"

Marco-Premier

Done. Sorry for the mistake. I flag that measurement/api/v2alpha/event_group_metadata/... still uses the _

Reviewable status: 0 of 4 files reviewed, 6 unresolved discussions (waiting on @kungfucraig, @SanjayVas, and @stevenwarejones)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 17 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

wfa.measurement.securecomputation.controlplane ?

Done.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 21 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Same as above.

Done.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

I think the AIP wants this to be called just "queue"

I'm not sure I follow @kungfucraig . I read the AIP and section ### Fields representing another resource which indicates the resource name to be string.

Isn't string queue = 2; correct? Can you please suggest what you mean by this to be called just "queue"?

thanks

kungfucraig

Reviewed 1 of 4 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Marco-Premier, @SanjayVas, and @stevenwarejones)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

Previously, Marco-Premier (marcopremier) wrote…

I'm not sure I follow @kungfucraig . I read the AIP and section ### Fields representing another resource which indicates the resource name to be string.

Isn't string queue = 2; correct? Can you please suggest what you mean by this to be called just "queue"?

thanks

I read: "queue_identifier" before. Looks good now. Sorry for any confusion.

src/main/proto/wfa/measurement/securecomputation/controlplane/v1alpha/work_items_service.proto line 30 at r4 (raw file):

    //
    // Enqueues the `WorkItem` into the appropriate queue.
    // Results in PERMISSION_DENIED if the queue_identifier specified in the `WorkItem`

nit: s/queue_identifier/queue

stevenwarejones

Reviewed 2 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Marco-Premier and @SanjayVas)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

I read: "queue_identifier" before. Looks good now. Sorry for any confusion.

I'd prefer a queue message type

message queue {
    string name;
}

kungfucraig

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Marco-Premier and @SanjayVas)

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

I'd prefer a queue message type
message queue {
    string name;
}

Can we just follow the AIP for this? https://google.aip.dev/122#fields-representing-another-resource

SanjayVas

Reviewed 1 of 4 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Marco-Premier)

a discussion (no related file):
Add this as an included path in src/main/proto/api-linter.yaml and update .github/workflows/api-lint.yml to lint this API.

Marco-Premier

Reviewable status: 1 of 7 files reviewed, 2 unresolved discussions (waiting on @kungfucraig, @SanjayVas, and @stevenwarejones)

a discussion (no related file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Add this as an included path in src/main/proto/api-linter.yaml and update .github/workflows/api-lint.yml to lint this API.

Done.

SanjayVas

Reviewed 5 of 6 files at r5, all commit messages.
Reviewable status: 6 of 7 files reviewed, 5 unresolved discussions (waiting on @kungfucraig, @Marco-Premier, and @stevenwarejones)

MODULE.bazel.lock line 2505 at r5 (raw file):

        ]
      },
      "os:osx,arch:aarch64": {

This shouldn't have needed changing in this PR as MODULE.bazel was not updated.

src/main/proto/api-linter.yaml line 51 at r5 (raw file):

  - 'wfa/measurement/securecomputation/controlplane/v1*/*.proto'
  disabled_rules:
  - 'core::0133::request-id-field'

nit: would you mind documenting why each of these is disabled like is done for the system API?

src/main/proto/api-linter.yaml line 54 at r5 (raw file):

  - 'core::0121::resource-must-support-get'
  - 'core::0121::resource-must-support-list'
  - 'core::0203::field-behavior-required'

New APIs should not disable this rule. As documented above, it's only disabled for the other API as the corresponding AIP and rule were added later.

Code quote:

  - 'core::0203::field-behavior-required'

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Can we just follow the AIP for this? https://google.aip.dev/122#fields-representing-another-resource

To clarify my above statement, this means making a Queue resource type and adding a resource reference annotation here.

kungfucraig

Reviewed 2 of 6 files at r5, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Marco-Premier and @stevenwarejones)

stevenwarejones

Reviewed 1 of 4 files at r3, 3 of 6 files at r5, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Marco-Premier and @SanjayVas)

MODULE.bazel.lock line 2505 at r5 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

This shouldn't have needed changing in this PR as MODULE.bazel was not updated.

I'm guessing this was added this he compiled it on a mac? If that's the case, this will keep popping up and I suggest just keeping it.

SanjayVas

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Marco-Premier and @stevenwarejones)

MODULE.bazel.lock line 2505 at r5 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

I'm guessing this was added this he compiled it on a mac? If that's the case, this will keep popping up and I suggest just keeping it.

This project is never intended to be compiled on a Mac, so this should in fact not be added.

Marco-Premier

Reviewable status: 2 of 8 files reviewed, 4 unresolved discussions (waiting on @kungfucraig, @SanjayVas, and @stevenwarejones)

MODULE.bazel.lock line 2505 at r5 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

This project is never intended to be compiled on a Mac, so this should in fact not be added.

Reset file to its original content

src/main/proto/api-linter.yaml line 54 at r5 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

New APIs should not disable this rule. As documented above, it's only disabled for the other API as the corresponding AIP and rule were added later.

Done.

confidential_computing/control_plane/src/main/proto/wfa/controlplane/work_item.proto line 37 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

To clarify my above statement, this means making a Queue resource type and adding a resource reference annotation here.

Done.

SanjayVas

Reviewed 6 of 6 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Marco-Premier and @stevenwarejones)

MODULE.bazel.lock line 2505 at r5 (raw file):

Previously, Marco-Premier (marcopremier) wrote…

Reset file to its original content

Still seeing some diffs here.

Renamed packages. Added Queue proto type.

Reset module.bazel.lock file to its original content Fix lint.yml

Marco-Premier

Reviewed 1 of 4 files at r3, 1 of 6 files at r5, 2 of 6 files at r6, 4 of 4 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

mikkokotila · 2024-12-23T10:24:03Z

Added feat prefix to the title.

Marco-Premier assigned kungfucraig, SanjayVas and stevenwarejones Oct 9, 2024

stevenwarejones requested changes Oct 9, 2024

View reviewed changes

SanjayVas requested review from kungfucraig and stevenwarejones October 10, 2024 17:33

SanjayVas requested changes Oct 10, 2024

View reviewed changes

Marco-Premier commented Oct 11, 2024

View reviewed changes

stevenwarejones reviewed Oct 11, 2024

View reviewed changes

kungfucraig requested changes Oct 11, 2024

View reviewed changes

SanjayVas requested review from kungfucraig and stevenwarejones October 11, 2024 18:06

SanjayVas requested changes Oct 11, 2024

View reviewed changes

stevenwarejones requested changes Oct 11, 2024

View reviewed changes

Marco-Premier commented Oct 16, 2024

View reviewed changes

kungfucraig requested changes Oct 16, 2024

View reviewed changes

Marco-Premier commented Oct 16, 2024

View reviewed changes

kungfucraig approved these changes Oct 16, 2024

View reviewed changes

stevenwarejones requested a review from SanjayVas October 16, 2024 20:29

stevenwarejones approved these changes Oct 16, 2024

View reviewed changes

kungfucraig approved these changes Oct 16, 2024

View reviewed changes

SanjayVas requested changes Oct 16, 2024

View reviewed changes

Marco-Premier commented Oct 17, 2024

View reviewed changes

SanjayVas requested review from kungfucraig and stevenwarejones October 17, 2024 17:21

SanjayVas requested changes Oct 17, 2024

View reviewed changes

kungfucraig approved these changes Oct 18, 2024

View reviewed changes

stevenwarejones reviewed Oct 18, 2024

View reviewed changes

SanjayVas requested a review from stevenwarejones October 18, 2024 18:02

SanjayVas requested changes Oct 18, 2024

View reviewed changes

Marco-Premier commented Oct 21, 2024

View reviewed changes

SanjayVas approved these changes Oct 21, 2024

View reviewed changes

Marco Premier and others added 14 commits October 22, 2024 00:24

Add proto definitions needed for CreateWorkItem rpc method

afb7429

Add v1alpha folder.

27468ec

Renamed packages. Added Queue proto type.

Renamed folder from confidential_computing to secure_computation

b21f804

Add build bazel file

714635e

Refactor package naming

9e0a5c9

removed underscore from packages

9ecd3be

Update api linter

7b81e42

Linted code

57aa748

Add missing imports in work item service

78147d5

Set grpc only

df476ec

Reverted MODULE.bazel.lock

6a5c23d

Added queue.proto with resource reference annotation

b348e3d

Reset module.bazel.lock file to its original content Fix lint.yml

Overwrite MODULE.bazel.lock using the one from main branch

5b4c31d

Lint proto files

b714ebc

Marco-Premier force-pushed the marcopremier/control-plane-proto-definitions branch from b884c35 to b714ebc Compare October 22, 2024 07:30

Marco-Premier commented Oct 22, 2024

View reviewed changes

Marco-Premier merged commit 80b8c44 into main Oct 22, 2024
4 checks passed

Marco-Premier deleted the marcopremier/control-plane-proto-definitions branch October 22, 2024 09:21

Marco-Premier mentioned this pull request Dec 9, 2024

Controlplane api #1890

Open

mikkokotila changed the title ~~ControlPlane initial proto definitions.~~ feat: ControlPlane initial proto definitions. Dec 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ControlPlane initial proto definitions. #1843

feat: ControlPlane initial proto definitions. #1843

Marco-Premier commented Oct 9, 2024

wfa-reviewable commented Oct 9, 2024

stevenwarejones left a comment

SanjayVas left a comment

Marco-Premier left a comment

stevenwarejones left a comment

kungfucraig left a comment

SanjayVas left a comment

SanjayVas left a comment

stevenwarejones left a comment

Marco-Premier left a comment

kungfucraig left a comment

Marco-Premier left a comment

kungfucraig left a comment

stevenwarejones left a comment

kungfucraig left a comment

SanjayVas left a comment

Marco-Premier left a comment

SanjayVas left a comment

kungfucraig left a comment

stevenwarejones left a comment

SanjayVas left a comment

Marco-Premier left a comment

SanjayVas left a comment

Marco-Premier left a comment

mikkokotila commented Dec 23, 2024

feat: ControlPlane initial proto definitions. #1843

feat: ControlPlane initial proto definitions. #1843

Conversation

Marco-Premier commented Oct 9, 2024

wfa-reviewable commented Oct 9, 2024

stevenwarejones left a comment

Choose a reason for hiding this comment

SanjayVas left a comment

Choose a reason for hiding this comment

Marco-Premier left a comment

Choose a reason for hiding this comment

stevenwarejones left a comment

Choose a reason for hiding this comment

kungfucraig left a comment

Choose a reason for hiding this comment

SanjayVas left a comment

Choose a reason for hiding this comment

SanjayVas left a comment

Choose a reason for hiding this comment

stevenwarejones left a comment

Choose a reason for hiding this comment

Marco-Premier left a comment

Choose a reason for hiding this comment

kungfucraig left a comment

Choose a reason for hiding this comment

Marco-Premier left a comment

Choose a reason for hiding this comment

kungfucraig left a comment

Choose a reason for hiding this comment

stevenwarejones left a comment

Choose a reason for hiding this comment

kungfucraig left a comment

Choose a reason for hiding this comment

SanjayVas left a comment

Choose a reason for hiding this comment

Marco-Premier left a comment

Choose a reason for hiding this comment

SanjayVas left a comment

Choose a reason for hiding this comment

kungfucraig left a comment

Choose a reason for hiding this comment

stevenwarejones left a comment

Choose a reason for hiding this comment

SanjayVas left a comment

Choose a reason for hiding this comment

Marco-Premier left a comment

Choose a reason for hiding this comment

SanjayVas left a comment

Choose a reason for hiding this comment

Marco-Premier left a comment

Choose a reason for hiding this comment

mikkokotila commented Dec 23, 2024