Fix Hardcoded Project ID in Terraform File #1579
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
src/main/terraform/gcloud/cmms/main.tf line 97 at r1 (raw file):
resource "google_project_iam_member" "cloud_traces_agent" { project = data.google_project.project.project_id
Sorry, I realized we have the google_client_config data resource already that can get this, so no need to add a google_project data resource.
data.google_client_config.default.project
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/terraform/gcloud/cmms/main.tf line 97 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Sorry, I realized we have the google_client_config data resource already that can get this, so no need to add a google_project data resource.
data.google_client_config.default.project
Done.
There was a problem hiding this comment.
Tested using tf plan in workflow.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
No description provided.