Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed logging to event groups and metadata descriptors services #1570

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

jcorilla
Copy link
Contributor

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@jcorilla jcorilla marked this pull request as ready for review April 15, 2024 22:01
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jcorilla and @Marco-Premier)


src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/common/KingdomInternalException.kt line 547 at r1 (raw file):

    get() =
      mapOf(
        "original_external_measurement_id" to

Nice catch, though also update the context keys.


src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/InternalStatusConversion.kt line 371 at r1 (raw file):

          put("providedMeasurementConsumer", providedMeasurementConsumerName)
          errorMessage =
            "EventGroup operation arguments original measurement: $originalMeasurementConsumerName and provided measurement: $providedMeasurementConsumerName invalid."

The actual issue here is that the MC references don't match

Suggestion:

"EventGroup argument invalid: expected $originalMeasurementConsumerName but got $providedMeasurementConsumerName"

@jcorilla jcorilla force-pushed the jcorilla-event-group-services-logging-update branch from 5c9ccd1 to 3f0e73a Compare April 16, 2024 07:58
Copy link
Contributor Author

@jcorilla jcorilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 12 of 14 files reviewed, 2 unresolved discussions (waiting on @Marco-Premier and @SanjayVas)


src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/common/KingdomInternalException.kt line 547 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Nice catch, though also update the context keys.

Done.


src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/InternalStatusConversion.kt line 371 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

The actual issue here is that the MC references don't match

Done.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Marco-Premier)

Copy link
Contributor

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 14 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jcorilla)

@jcorilla jcorilla force-pushed the jcorilla-event-group-services-logging-update branch from 3f0e73a to fb3a918 Compare April 17, 2024 17:57
@jcorilla jcorilla force-pushed the jcorilla-event-group-services-logging-update branch from fb3a918 to 185e343 Compare April 17, 2024 20:27
@jcorilla jcorilla merged commit 985f1f2 into main Apr 17, 2024
4 checks passed
@jcorilla jcorilla deleted the jcorilla-event-group-services-logging-update branch April 17, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants