-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detailed logging to event groups and metadata descriptors services #1570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jcorilla and @Marco-Premier)
src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/common/KingdomInternalException.kt
line 547 at r1 (raw file):
get() = mapOf( "original_external_measurement_id" to
Nice catch, though also update the context keys.
src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/InternalStatusConversion.kt
line 371 at r1 (raw file):
put("providedMeasurementConsumer", providedMeasurementConsumerName) errorMessage = "EventGroup operation arguments original measurement: $originalMeasurementConsumerName and provided measurement: $providedMeasurementConsumerName invalid."
The actual issue here is that the MC references don't match
Suggestion:
"EventGroup argument invalid: expected $originalMeasurementConsumerName but got $providedMeasurementConsumerName"
5c9ccd1
to
3f0e73a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 12 of 14 files reviewed, 2 unresolved discussions (waiting on @Marco-Premier and @SanjayVas)
src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/common/KingdomInternalException.kt
line 547 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Nice catch, though also update the context keys.
Done.
src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/InternalStatusConversion.kt
line 371 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
The actual issue here is that the MC references don't match
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Marco-Premier)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 14 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jcorilla)
3f0e73a
to
fb3a918
Compare
fb3a918
to
185e343
Compare
No description provided.