Add detailed logging to ExchangeSteps and Attempts services #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jcorilla
force-pushed
the
jcorilla-exchange-step-logging-update
branch
from
e7420f1 to
42efd2a
Compare
SanjayVas
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jcorilla and @Marco-Premier)
src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/SpannerExchangeStepsService.kt line 55 at r1 (raw file):
.readByExternalIds( client.singleUse(), ExternalId(request.externalRecurringExchangeId),
nit: extract to variable since it's used more than once
Code quote:
ExternalId(request.externalRecurringExchangeId)
jcorilla
force-pushed
the
jcorilla-exchange-step-logging-update
branch
from
a5c4b4f to
7d2c019
Compare
Marco-Premier
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Reviewed 9 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jcorilla)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.