-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflows for QA environment. #1546
Conversation
854027e
to
b472251
Compare
b472251
to
003d1dc
Compare
003d1dc
to
a6b7815
Compare
559f47a
to
29e4b56
Compare
29e4b56
to
d022ea6
Compare
d022ea6
to
8debc97
Compare
8debc97
to
f66033d
Compare
b6dc9fc
to
78b36b7
Compare
f66033d
to
7b7c617
Compare
7b7c617
to
7a4a1b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
.github/workflows/deploy-qa.yml
line 15 at r1 (raw file):
# limitations under the License. name: Deploy to dev environment
Are there any reason why we only want this workflow for qa env?
7a4a1b8
to
b0b358a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 22 of 23 files reviewed, 1 unresolved discussion (waiting on @YuhongWang-Amazon)
.github/workflows/deploy-qa.yml
line 15 at r1 (raw file):
Previously, YuhongWang-Amazon wrote…
Are there any reason why we only want this workflow for qa env?
This is the workflow for deploying on release. I renamed it to make that more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
This includes updating TLS certificates to add subject alternative names for qa.halo-cmm.org.
This includes updating TLS certificates to add subject alternative names for qa.halo-cmm.org.