Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows for QA environment. #1546

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Update workflows for QA environment. #1546

merged 1 commit into from
Apr 3, 2024

Conversation

SanjayVas
Copy link
Member

This includes updating TLS certificates to add subject alternative names for qa.halo-cmm.org.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-qa-certs branch from 854027e to b472251 Compare March 28, 2024 22:06
@SanjayVas SanjayVas force-pushed the sanjayvas-qa-certs branch from b472251 to 003d1dc Compare March 28, 2024 22:24
@SanjayVas SanjayVas force-pushed the sanjayvas-qa-certs branch from 003d1dc to a6b7815 Compare March 28, 2024 23:52
@SanjayVas SanjayVas force-pushed the sanjayvas-qa-certs branch 2 times, most recently from 559f47a to 29e4b56 Compare March 29, 2024 00:22
@SanjayVas SanjayVas changed the base branch from main to sanjayvas-k8s-dev-duchy March 29, 2024 00:24
@SanjayVas SanjayVas force-pushed the sanjayvas-qa-certs branch from 29e4b56 to d022ea6 Compare March 29, 2024 00:40
@SanjayVas SanjayVas force-pushed the sanjayvas-qa-certs branch from d022ea6 to 8debc97 Compare March 29, 2024 00:55
Copy link
Contributor

@YuhongWang-Amazon YuhongWang-Amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


.github/workflows/deploy-qa.yml line 15 at r1 (raw file):

# limitations under the License.

name: Deploy to dev environment

Are there any reason why we only want this workflow for qa env?

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 22 of 23 files reviewed, 1 unresolved discussion (waiting on @YuhongWang-Amazon)


.github/workflows/deploy-qa.yml line 15 at r1 (raw file):

Previously, YuhongWang-Amazon wrote…

Are there any reason why we only want this workflow for qa env?

This is the workflow for deploying on release. I renamed it to make that more clear.

Copy link
Contributor

@YuhongWang-Amazon YuhongWang-Amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas merged commit b3d3a74 into main Apr 3, 2024
4 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-qa-certs branch April 3, 2024 18:26
ple13 pushed a commit that referenced this pull request Aug 16, 2024
This includes updating TLS certificates to add subject alternative names for qa.halo-cmm.org.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants