Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed logging for public api keys service #1541

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

jcorilla
Copy link
Contributor

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jcorilla and @tristanvuong2021)


src/test/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/ApiKeysServiceTest.kt line 61 at r1 (raw file):

private const val API_KEY_NAME_2 = "$MEASUREMENT_CONSUMER_NAME_2/apiKeys/AAAAAAAAANs"
private const val AUTHENTICATION_KEY = 12345672L
private val EXTERNAL_MEASUREMENT_CONSUMER_ID =

nit: invert this and have the name be built from the external ID. (AAAAAAAAAHs is 123, AAAAAAAAAJs is 155)

https://pl.kotl.in/Tcq-YnwzI

@jcorilla jcorilla requested a review from Marco-Premier March 27, 2024 22:44
Copy link
Contributor

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

@jcorilla jcorilla merged commit 4017046 into main Mar 29, 2024
4 checks passed
@jcorilla jcorilla deleted the jcorilla-apikeys-service-logging-update branch March 29, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants