Replace one update call per row with one update call for multiple rows #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
…-large-update-per-table
…-large-update-per-table
SanjayVas
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
…-large-update-per-table
stevenwarejones
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
…-large-update-per-table
tristanvuong2021
deleted the
tristanvuong-replace-separate-updates-with-1-large-update-per-table
branch
ple13
pushed a commit
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addBinding method executes one update per row. When the number of rows is large, the performance suffers. For 800 measurements, update takes 1.4 seconds locally. With the change in this PR, update takes 0.8 seconds.
The refactoring is done this way because R2DBC doesn't automically transform the update into a single batch update. See pgjdbc/r2dbc-postgresql#527.