Fix race conditions in empty cluster K8s tests. #1517
Conversation
SanjayVas
commented
Mar 7, 2024
•
SanjayVas
commented
- List Pods using current ReplicaSet rather than Deployment match labels.
- Wait for all Deployments to be complete after apply operations.
|
This change is |
SanjayVas
force-pushed
the
sanjayvas-panelmatch-wait
branch
from
22fa87d to
33ff31e
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @Marco-Premier and @SanjayVas)
a discussion (no related file):
Still hitting a race condition. Will update this comment when I figure it out
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
a discussion (no related file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Still hitting a race condition. Will update this comment when I figure it out
I noticed that waitUntilDeploymentsReady returns if the old deployment was deployed already, without waiting for the new apply to take effect.
Maybe we can check if the pod name changes? Or simply set a time out even though it would be "flaky" and not deterministic
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
a discussion (no related file):
I noticed that
waitUntilDeploymentsReadyreturns if the old deployment was deployed already
IIUC, the Deployment doesn't get replaced. It should be the same deployment, just with different state.
SanjayVas
force-pushed
the
sanjayvas-panelmatch-wait
branch
2 times, most recently
from
f8918a7 to
a813002
Compare
There was a problem hiding this comment.
Depends on world-federation-of-advertisers/common-jvm#237
Reviewable status: 3 of 11 files reviewed, all discussions resolved (waiting on @Marco-Premier)
SanjayVas
force-pushed
the
sanjayvas-panelmatch-wait
branch
2 times, most recently
from
69baa4c to
b426714
Compare
SanjayVas
changed the title
There was a problem hiding this comment.
Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
This fixes a race condition where the port forwarding may be pointing to the Kingdom pod used for resource setup.
SanjayVas
force-pushed
the
sanjayvas-panelmatch-wait
branch
from
b426714 to
cf321bf
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status:
* List Pods using current ReplicaSet rather than Deployment match labels. * Wait for all Deployments to be complete after apply operations.
