-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement v2alpha public API DataProviders service. #151
Conversation
b9f5bc3
to
94c6d18
Compare
94c6d18
to
6db6593
Compare
52af246
to
18861d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
a discussion (no related file):
We will want a nearly identical service for registering ModelProviders too. Are there parts that we could pull out into helper libraries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein)
a discussion (no related file):
Previously, efoxepstein (Eli Fox-Epstein) wrote…
We will want a nearly identical service for registering ModelProviders too. Are there parts that we could pull out into helper libraries?
My plan was to identify these as I add MeasurementConsumers. Likely the certificate parts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
18861d0
to
1218237
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oliver-amzn, @SanjayVas, @stevenwarejones, and @zachcwc)
src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/DataProvidersService.kt, line 45 at r1 (raw file):
class DataProvidersService(private val internalClient: DataProvidersCoroutineStub) : DataProvidersCoroutineService() { override suspend fun createDataProvider(request: CreateDataProviderRequest): DataProvider {
is the plan to implement the create method and hide it from the public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oliver-amzn, @stevenwarejones, @wangyaopw, and @zachcwc)
src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/DataProvidersService.kt, line 45 at r1 (raw file):
Previously, wangyaopw (Yao Wang) wrote…
is the plan to implement the create method and hide it from the public?
AFAIK methods can't be hidden, only entire services can.
If we choose to not allow self-service registration, we have a few options. For example:
- For alpha, the current thinking is to lock down the entire Accounts service so that only those with direct access to the cluster can create Accounts and therefore DataProvider/MeasurementConsumer resources. The EDP or MC user would then just be given an API key.
- If this is a requirement for a public deployment, we can restrict access to this method to a configured set of client TLS certificates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oliver-amzn, @stevenwarejones, and @wangyaopw)
1218237
to
223e1f8
Compare
This change is