Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v2alpha public API DataProviders service. #151

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented Jul 14, 2021

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-data-providers branch from b9f5bc3 to 94c6d18 Compare July 16, 2021 18:50
@SanjayVas SanjayVas changed the base branch from sanjayvas-certificates to main July 16, 2021 18:52
@SanjayVas SanjayVas force-pushed the sanjayvas-data-providers branch from 94c6d18 to 6db6593 Compare July 16, 2021 18:52
@SanjayVas SanjayVas marked this pull request as ready for review July 16, 2021 18:53
@SanjayVas SanjayVas requested a review from efoxepstein July 16, 2021 18:53
@SanjayVas SanjayVas force-pushed the sanjayvas-data-providers branch 2 times, most recently from 52af246 to 18861d0 Compare July 16, 2021 19:47
Copy link
Contributor

@efoxepstein efoxepstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)

a discussion (no related file):
We will want a nearly identical service for registering ModelProviders too. Are there parts that we could pull out into helper libraries?


Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein)

a discussion (no related file):

Previously, efoxepstein (Eli Fox-Epstein) wrote…

We will want a nearly identical service for registering ModelProviders too. Are there parts that we could pull out into helper libraries?

My plan was to identify these as I add MeasurementConsumers. Likely the certificate parts.


Copy link
Contributor

@efoxepstein efoxepstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

Copy link
Contributor

@wangyaopw wangyaopw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oliver-amzn, @SanjayVas, @stevenwarejones, and @zachcwc)


src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/DataProvidersService.kt, line 45 at r1 (raw file):

class DataProvidersService(private val internalClient: DataProvidersCoroutineStub) :
  DataProvidersCoroutineService() {
  override suspend fun createDataProvider(request: CreateDataProviderRequest): DataProvider {

is the plan to implement the create method and hide it from the public?

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oliver-amzn, @stevenwarejones, @wangyaopw, and @zachcwc)


src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/DataProvidersService.kt, line 45 at r1 (raw file):

Previously, wangyaopw (Yao Wang) wrote…

is the plan to implement the create method and hide it from the public?

AFAIK methods can't be hidden, only entire services can.

If we choose to not allow self-service registration, we have a few options. For example:

  • For alpha, the current thinking is to lock down the entire Accounts service so that only those with direct access to the cluster can create Accounts and therefore DataProvider/MeasurementConsumer resources. The EDP or MC user would then just be given an API key.
  • If this is a requirement for a public deployment, we can restrict access to this method to a configured set of client TLS certificates.

Copy link

@zachcwc zachcwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oliver-amzn, @stevenwarejones, and @wangyaopw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants