-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI features from Demo work #1495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bdomen-ggl)
experimental/reporting-ui/src/main/react/reporting-ui/public/manifest.json
line 6 at r1 (raw file):
"icons": [ { "src": "favicon.png",
Is this generated from somewhere? I only see the .ico file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 22 of 23 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
experimental/reporting-ui/src/main/react/reporting-ui/public/manifest.json
line 6 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Is this generated from somewhere? I only see the .ico file.
Ah yeah that should technically be favicon.ico. Don't know why it worked when I built it though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @bdomen-ggl)
bacf1b6
to
98da97e
Compare
Add several small UI features for demo change request.
Several small changes from added features during the demo:
Bug Fixes: