Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI features from Demo work #1495

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Add UI features from Demo work #1495

merged 2 commits into from
Feb 26, 2024

Conversation

bdomen-ggl
Copy link
Contributor

Several small changes from added features during the demo:

  • Added the "demo" banner at the top of the site and made it sticky.
  • Updated some card labels in the Report view and adjusted the styles so the columns aren't fixed. Didn't specifically get feedback from UX on the behavior but this was requested from users.
  • Also made the summary cards more flexible for different content.
  • Added an overflow to the card in case the user is on a small screen. This was noticeable in the summary table.
  • Removed "on target reach" from the charts.
  • Updated the title.
  • Added Google Analytics.

Bug Fixes:

  • Added a margin at the bottom of the site so the feedback button isn't stuck over things at the bottom like charts.
  • Fixed fonts. There was an extra "./" in the font src that would work locally but screw up webpack with routes on the server. Also removed the extra font styles and just left sans serif.
  • Added more cases to the number to magnitude converter including handling the 0 case to make the logic simpler.
  • Updated BUILD files for some ChartGroups. These charts were removed from the current UI so they didn't fail the build.

@wfa-reviewable
Copy link

This change is Reviewable

@bdomen-ggl bdomen-ggl requested a review from SanjayVas February 21, 2024 17:30
@bdomen-ggl bdomen-ggl marked this pull request as ready for review February 21, 2024 17:30
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bdomen-ggl)


experimental/reporting-ui/src/main/react/reporting-ui/public/manifest.json line 6 at r1 (raw file):

  "icons": [
    {
      "src": "favicon.png",

Is this generated from somewhere? I only see the .ico file.

Copy link
Contributor Author

@bdomen-ggl bdomen-ggl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 22 of 23 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


experimental/reporting-ui/src/main/react/reporting-ui/public/manifest.json line 6 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Is this generated from somewhere? I only see the .ico file.

Ah yeah that should technically be favicon.ico. Don't know why it worked when I built it though.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bdomen-ggl)

@bdomen-ggl bdomen-ggl force-pushed the bdomen-ui-demoUpdates branch from bacf1b6 to 98da97e Compare February 26, 2024 15:13
@bdomen-ggl bdomen-ggl merged commit 8ea3a4b into main Feb 26, 2024
4 checks passed
@bdomen-ggl bdomen-ggl deleted the bdomen-ui-demoUpdates branch February 26, 2024 15:40
ple13 pushed a commit that referenced this pull request Aug 16, 2024
Add several small UI features for demo change request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants