Update SetParticipantParams for HMSS protocol

[renjiezh]

No description provided.

[wfa-reviewable]

This change is 

[SanjayVas]

Reviewed 50 of 50 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/common/HmssProtocolConfig.kt line 28 at r2 (raw file):

    private set

  /** A set of external duchy ids that the first one must correspond to the aggregator. */

nit: Phrasing

Suggestion:

Set of external IDs of required Duchies, where the first entry must correspond to the Duchy in the aggregator role.

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/CreateMeasurements.kt line 185 at r2 (raw file):

      }
      ProtocolConfig.ProtocolCase.HONEST_MAJORITY_SHARE_SHUFFLE -> {
        // For each EDP, insert a Requisitions for each non-aggregator.

nit

Suggestion:

For each EDP, insert a Requisition for each non-aggregator Duchy.

---

src/main/kotlin/org/wfanet/measurement/kingdom/service/internal/testing/ComputationParticipantsServiceTest.kt line 513 at r2 (raw file):

    val nonUpdatedMeasurement =
      measurementsService.getMeasurementByComputationId(
        GetMeasurementByComputationIdRequest.newBuilder()

Use Kotlin DSL builder

Code quote:

GetMeasurementByComputationIdRequest.newBuilder()

---

src/main/kotlin/org/wfanet/measurement/kingdom/service/internal/testing/Population.kt line 347 at r2 (raw file):

        measurementSpecSignatureAlgorithmOid = "2.9999"
        duchyProtocolConfig = duchyProtocolConfig {
          liquidLegionsV2 = DuchyProtocolConfigKt.liquidLegionsV2 {}

Why does this have anything set for LLv2?

---

src/main/proto/wfa/measurement/system/v1alpha/computation_participant.proto line 111 at r2 (raw file):

      //
      // If not specified, this is assumed to be the signature algorithm of the
      // accompanying certificate

We only had this for backwards-compatibility for existing fields. Since this is a new protocol, this can be required instead.

Code quote:

      // If not specified, this is assumed to be the signature algorithm of the
      // accompanying certificate

[renjiezh]

Reviewable status: 45 of 50 files reviewed, 3 unresolved discussions (waiting on @SanjayVas)

---

src/main/kotlin/org/wfanet/measurement/kingdom/service/internal/testing/ComputationParticipantsServiceTest.kt line 513 at r2 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Use Kotlin DSL builder

Done.

---

src/main/kotlin/org/wfanet/measurement/kingdom/service/internal/testing/Population.kt line 347 at r2 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Why does this have anything set for LLv2?

Done.
Nice catch. Deleted.

---

src/main/proto/wfa/measurement/system/v1alpha/computation_participant.proto line 111 at r2 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

We only had this for backwards-compatibility for existing fields. Since this is a new protocol, this can be required instead.

Done.

[SanjayVas]

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/kingdom/service/internal/testing/ComputationParticipantsServiceTest.kt line 80 at r3 (raw file):

private val TINK_PUBLIC_KEY_SIGNATURE =
  ByteString.copyFromUtf8("This is an Tink Public Key signature.")
private val TINK_PUBLIC_KEY_SIGNATURE_ALGORTIHM_OID = "4.99"

nit: use a valid registered OID. 2.9999 is an OID specifically for examples.

Suggestion:

2.9999

---

src/main/kotlin/org/wfanet/measurement/kingdom/service/internal/testing/Population.kt line 347 at r3 (raw file):

        measurementSpecSignatureAlgorithmOid = "2.9999"
        protocolConfig = protocolConfig {
          honestMajorityShareShuffle = ProtocolConfigKt.honestMajorityShareShuffle {}

nit: Prefer getDefaultInstance

Suggestion:

ProtocolConfig.HonestMajorityShareShuffle.getDefaultInstance()

---

src/main/proto/wfa/measurement/system/v1alpha/computation_participant.proto line 111 at r2 (raw file):

Previously, renjiezh wrote…

Done.

Add the REQUIRED field behavior annotation too.

[renjiezh]

Reviewable status: 47 of 50 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)

---

src/main/proto/wfa/measurement/system/v1alpha/computation_participant.proto line 111 at r2 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Add the REQUIRED field behavior annotation too.

Done.

[SanjayVas]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)

[stevenwarejones]

Reviewed 45 of 50 files at r2, 2 of 5 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)