return all buckets if privacy bucket mappers operative field set is empty

[stevenwarejones]

…mpty

[wfa-reviewable]

This change is 

[uakyol]

Thank you. While you are here, I think it will be good to also add a comment here that states if the operative fields are empty, normalization operation is not done.

[uakyol]

Reviewed 2 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

[SanjayVas]

Reviewed 1 of 6 files at r1, 4 of 4 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @stevenwarejones)

---

src/main/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/PrivacyBucketMapper.kt line 36 at r3 (raw file):

  /**
   * Returns if a [privacyBucketGroup] matches for a given cel [program]. Always returns true if

nit

Suggestion:

whether

---

src/main/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/PrivacyBucketMapper.kt line 36 at r3 (raw file):

  /**
   * Returns if a [privacyBucketGroup] matches for a given cel [program]. Always returns true if

nit

Suggestion:

`true`

---

src/main/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/testing/AlwaysChargingPrivacyBucketMapper.kt line 43 at r3 (raw file):

  override fun toEventMessage(privacyBucketGroup: PrivacyBucketGroup): Message {
    return testEvent {}

nit

Suggestion:

TestEvent.getDefaultInstance()

---

src/test/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/PrivacyBucketFilterTest.kt line 274 at r3 (raw file):

  @Test
  fun `Mapper succeeds with empty operative fields`() {

nit: Generally tests methods should follow the pattern of " when ".

Suggestion:

getPrivacyBucketGroups returns all groups when mapper operativeFields is empty

[SanjayVas]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @stevenwarejones)

---

src/test/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/PrivacyBucketFilterTest.kt line 274 at r3 (raw file):
Sorry, formatting ate my comment.

"<MUT> <action> [when <condition>]"

[stevenwarejones]

Reviewed 3 of 4 files at r2, 1 of 2 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)