Update cross-media-measurement-api dep for exchange API changes. #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Oct 6, 2023
SanjayVas
force-pushed
the
sanjayvas-exchange-api
branch
3 times, most recently
from
301218a to
f107829
Compare
Marco-Premier
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Reviewed 60 of 60 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
SanjayVas
force-pushed
the
sanjayvas-exchange-api
branch
2 times, most recently
from
bf5be0a to
b5be62c
Compare
SanjayVas
force-pushed
the
sanjayvas-common-cpp
branch
from
3c7e32a to
9d46a05
Compare
In addition to handling the API definition changes, this fixes various issues with the service implementations for the RecurringExchange resource tree: * Handle secondary name patterns for RecurringExchange resources. * Fix pagination implementation for ListExchangeSteps. * Update authorization checks to better comply with AIP-211. This makes breaking changes to the Kingdom internal API.
SanjayVas
force-pushed
the
sanjayvas-exchange-api
branch
from
b5be62c to
84bdd61
Compare
SanjayVas
commented
Oct 11, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
ple13
pushed a commit
that referenced
this pull request
Aug 16, 2024
In addition to handling the API definition changes, this fixes various issues with the service implementations for the RecurringExchange resource tree: * Handle secondary name patterns for RecurringExchange resources. * Fix pagination implementation for ListExchangeSteps. * Update authorization checks to better comply with AIP-211. This makes breaking changes to the Kingdom internal API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to handling the API definition changes, this fixes various issues with the service implementations for the RecurringExchange resource tree:
This makes breaking changes to the Kingdom internal API.