Update integration tests to verify direct measurement results

[riemanli]

No description provided.

[wfa-reviewable]

This change is 

[riemanli]

Current dependencies on/for this PR:

• main
  • PR Update integration tests to verify direct measurement results #1212 👈

This comment was auto-generated by Graphite.

[SanjayVas]

Add integration tests for direct measurements.

nit: technically this isn't adding integration tests for direct measurements, but rather updating integration tests to verify direct methodologies.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riemanli)

---

src/main/kotlin/org/wfanet/measurement/loadtest/measurementconsumer/MeasurementConsumerSimulator.kt line 240 at r1 (raw file):

          reachAndFrequencyResult.reach.noiseMechanism == NoiseMechanism.CONTINUOUS_GAUSSIAN
      )
      .isTrue()

Suggestion:

    assertThat(reachAndFrequencyResult.reach.noiseMechanism)
      .isIn(listOf(NoiseMechanism.CONTINUOUS_LAPLACE, NoiseMechanism.CONTINUOUS_GAUSSIAN))

[riemanli]

Thanks for the suggestion. Updated the title to reflect the real change.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)

---

src/main/kotlin/org/wfanet/measurement/loadtest/measurementconsumer/MeasurementConsumerSimulator.kt line 240 at r1 (raw file):

          reachAndFrequencyResult.reach.noiseMechanism == NoiseMechanism.CONTINUOUS_GAUSSIAN
      )
      .isTrue()

Based on an offline discussion, we made the expected direct noise mechanism configurable from the constructor argument. That said, now the caller of the MC simulator needs to specified what the expected direct noise mechanism is according to their protocol config and EDP simulator setup.

[SanjayVas]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riemanli)

[SanjayVas]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @riemanli)

---

src/test/kotlin/org/wfanet/measurement/integration/k8s/SyntheticGeneratorCorrectnessTest.kt line 47 at r2 (raw file):

/**
 * Test for correctness of an existing CMMS on Kubernetes where the EDP simulators use
 * [SyntheticGeneratorEventQuery] with [SyntheticGenerationSpecs.POPULATION_SPEC].

I believe you need to make the same note about assuming the simulators are using ACDP composition here.

[riemanli]

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @SanjayVas)

---

src/test/kotlin/org/wfanet/measurement/integration/k8s/SyntheticGeneratorCorrectnessTest.kt line 47 at r2 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

I believe you need to make the same note about assuming the simulators are using ACDP composition here.

Thanks for catching that! Added.

[SanjayVas]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @riemanli)

[Marco-Premier]

Reviewed 4 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

[stevenwarejones]

Reviewed 4 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @riemanli)