Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMMS testing certs for dev panel match. #1207

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

SanjayVas
Copy link
Member

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas
Copy link
Member Author

@Marco-Premier I forgot I had this code in my local working directory from helping out with some integration testing. Let me know if this is useful for the K8s test you're working on.

Copy link
Contributor

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me connect the dots first. I may reuse part of this code in the new daemon I'm creating. Will let you know in the next few days. And thanks for it :)

Reviewable status: 0 of 14 files reviewed, all discussions resolved

Copy link
Contributor

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SanjayVas , This code is definitely useful and I can reuse it for the forwarded-storage-edp... & forwarded-storage-mp... daemon I'm creating for the kind test.
Do you mind merging it?

thanks!

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas enabled auto-merge (squash) September 11, 2023 22:27
@SanjayVas SanjayVas merged commit 072bb9d into main Sep 11, 2023
@SanjayVas SanjayVas deleted the sanjayvas-panel-k8s branch September 11, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants