Adding show report skeleton to UI

[bdomen-ggl]

Adding the core pieces for the show report view.
Will add the actual UI components in the next PR since there's quite a few.

[wfa-reviewable]

This change is 

[bdomen-ggl]

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @SanjayVas and @stevenwarejones)

---

experimental/reporting-ui/src/main/react/reporting-ui/view/show_report/show_report_view.tsx line 43 at r1 (raw file):

  if (TERMINAL_STATES.includes(report.status)) {
    return <div>{report.name}</div>

Will add the components to render the report and update the UI model in the next PR.

We don't currently have designs for the other cases (error, loading, and a non-completed report).

[SanjayVas]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @bdomen-ggl and @stevenwarejones)

---

experimental/reporting-ui/src/main/react/reporting-ui/view/show_report/show_report_view.tsx line 22 at r1 (raw file):

import { TERMINAL_STATES } from '../../model/reporting';

export const ShowReportView = () => {

nit: Why the "Show"? Why not just ReportView?

Code quote:

ShowReportView

[bdomen-ggl]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SanjayVas and @stevenwarejones)

---

experimental/reporting-ui/src/main/react/reporting-ui/view/show_report/show_report_view.tsx line 22 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

nit: Why the "Show"? Why not just ReportView?

Yeah I was thinking about that too. But was wondering if I should then call the files/classes like "ReportViewView" and "ReportViewViewModel" - "ReportView" for the base description, and View and View Model as specifiers. The double "View" seemed odd. So was thinking about renaming the base description so terms don't overlap.

Or you mean like JUST "ReportView" and "ReportViewModel" without an additional description to Report? I can do that.

[SanjayVas]

Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)

---

experimental/reporting-ui/src/main/react/reporting-ui/view/show_report/show_report_view.tsx line 22 at r1 (raw file):

Or you mean like JUST "ReportView" and "ReportViewModel" without an additional description to Report? I can do that.

Yes. ReportView meaning the view for a single Report. We could rename to add other modifiers if end up with multiple views for a single Report, e.g. ReportSummaryView and ReportDetailsView.

[bdomen-ggl]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)

---

experimental/reporting-ui/src/main/react/reporting-ui/view/show_report/show_report_view.tsx line 22 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Or you mean like JUST "ReportView" and "ReportViewModel" without an additional description to Report? I can do that.

Yes. ReportView meaning the view for a single Report. We could rename to add other modifiers if end up with multiple views for a single Report, e.g. ReportSummaryView and ReportDetailsView.

Done.

Sorry, forgot to publish.