Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cross-media-measurement-api for max watch duration. #1192

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Update cross-media-measurement-api for max watch duration. #1192

merged 1 commit into from
Sep 7, 2023

Conversation

SanjayVas
Copy link
Member

Update the cross-media-measurement-api dependency for world-federation-of-advertisers/cross-media-measurement-api#167.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch from 4a7c2a8 to fa883cf Compare August 30, 2023 22:24
@SanjayVas SanjayVas force-pushed the sanjayvas-max-frequency branch from 1e5b89c to d6cc588 Compare August 31, 2023 17:36
@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch 2 times, most recently from bdcc0d6 to 0439ae5 Compare August 31, 2023 17:57
@SanjayVas SanjayVas force-pushed the sanjayvas-max-frequency branch from d6cc588 to 7ea8188 Compare August 31, 2023 21:24
@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch from 0439ae5 to 26343aa Compare August 31, 2023 21:24
stevenwarejones
stevenwarejones approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 30 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas
Copy link
Member Author

Depends on #1183

@SanjayVas SanjayVas force-pushed the sanjayvas-max-frequency branch from 7ea8188 to 1ee0d82 Compare September 1, 2023 16:39
@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch from 26343aa to 0d7aa8c Compare September 1, 2023 16:39
@SanjayVas SanjayVas force-pushed the sanjayvas-max-frequency branch from 1ee0d82 to de98f2b Compare September 5, 2023 22:26
@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch from 0d7aa8c to 5023dfd Compare September 5, 2023 22:26
stevenwarejones
stevenwarejones approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch from 5023dfd to 34d146b Compare September 6, 2023 21:06
@SanjayVas SanjayVas force-pushed the sanjayvas-max-frequency branch 2 times, most recently from 1242ea3 to 49d6abe Compare September 6, 2023 21:47
@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch from 34d146b to 220fcd3 Compare September 6, 2023 21:47
stevenwarejones
stevenwarejones approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-max-frequency branch from 49d6abe to fe9bbae Compare September 6, 2023 23:04
@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch 2 times, most recently from ed434c8 to a14a9e9 Compare September 7, 2023 00:54
@SanjayVas SanjayVas force-pushed the sanjayvas-max-frequency branch from fe9bbae to 960b0e2 Compare September 7, 2023 00:54
Base automatically changed from sanjayvas-max-frequency to main September 7, 2023 04:53
@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch 2 times, most recently from be3719b to f02411a Compare September 7, 2023 18:21
SanjayVas
SanjayVas commented Sep 7, 2023
View reviewed changes
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 6 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

@SanjayVas SanjayVas enabled auto-merge (squash) September 7, 2023 18:23
@SanjayVas SanjayVas mentioned this pull request Sep 7, 2023
Merged
@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch from f02411a to c0786aa Compare September 7, 2023 21:19
@SanjayVas SanjayVas disabled auto-merge September 7, 2023 21:19
@SanjayVas SanjayVas enabled auto-merge (squash) September 7, 2023 21:20
stevenwarejones
stevenwarejones approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-watch-duration branch from c0786aa to 72c8891 Compare September 7, 2023 21:57
@SanjayVas SanjayVas merged commit ecd72f9 into main Sep 7, 2023
@SanjayVas SanjayVas deleted the sanjayvas-watch-duration branch September 7, 2023 22:35
ple13 pushed a commit that referenced this pull request Aug 16, 2024
@SanjayVas @ple13
Update cross-media-measurement-api for max watch duration. (#1192)
91d1868 
Update the cross-media-measurement-api dependency to 0.41.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenwarejones stevenwarejones stevenwarejones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SanjayVas @wfa-reviewable @stevenwarejones