-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PrivacyQueryMapper for ACDP composition #1163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @iverson52000, @RibeiroAna, and @uakyol)
src/main/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/api/v2alpha/PrivacyQueryMapper.kt
line 29 at r1 (raw file):
import org.wfanet.measurement.eventdataprovider.privacybudgetmanagement.Reference private const val SENSITIVITY = 1.0
this should initialized with the object/class imo
13d020e
to
70da7ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @RibeiroAna, @stevenwarejones, and @uakyol)
src/main/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/api/v2alpha/PrivacyQueryMapper.kt
line 29 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
this should initialized with the object/class imo
Done. Make sense thanks
Previously, iverson52000 (Albert Hsu) wrote…
Do we ever want to initialize the PBM with a different sensitivity? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @RibeiroAna and @uakyol)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RibeiroAna and @stevenwarejones)
src/main/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/api/v2alpha/PrivacyQueryMapper.kt
line 29 at r1 (raw file):
Previously, uakyol wrote…
Do we ever want to initialize the PBM with a different sensitivity?
Synced offline, seems we would need to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RibeiroAna and @uakyol)
src/main/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/api/v2alpha/PrivacyQueryMapper.kt
line 29 at r1 (raw file):
Previously, uakyol wrote…
Synced offline, seems we would need to do this.
change this to a class with the sensitivity passed in to the constructor then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RibeiroAna and @stevenwarejones)
src/main/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/api/v2alpha/PrivacyQueryMapper.kt
line 29 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
change this to a class with the sensitivity passed in to the constructor then?
The SENSITIVITY is subject to change in the future in some ways. From Pasin, the SENSITIVITY may be different from 1.0 for impression
and duration
. It may be fixed constant, or an output from another function depends on the design of other ACDP PBM add-on features. I suggest we leave PrivacyQueryMapper
as it is for now and update it later when needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RibeiroAna)
70da7ef
to
e0037b4
Compare
No description provided.